Skip to content

[v13] Add in plugin bearer token credentials.#26436

Merged
mdwn merged 1 commit intobranch/v13from
mike.wilson/v13-plugin-bearer-token
May 17, 2023
Merged

[v13] Add in plugin bearer token credentials.#26436
mdwn merged 1 commit intobranch/v13from
mike.wilson/v13-plugin-bearer-token

Conversation

@mdwn
Copy link
Copy Markdown
Contributor

@mdwn mdwn commented May 17, 2023

The bearer token credentials have been pulled from the assist PR and migrated to v13 directly. This is needed to support the Okta plugin.

Note: This applies to v13 only, master had this bit pulled in as part of #25953

The bearer token credentials have been pulled from the assist PR and migrated
to v13 directly. This is needed to support the Okta plugin.
Copy link
Copy Markdown
Contributor

@jakule jakule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but wait for @justinas 👍 as he was the original author.

@jakule jakule requested a review from justinas May 17, 2023 13:23
Copy link
Copy Markdown
Contributor

@tigrato tigrato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment saying you should specify token or token_file but not both would be great

@mdwn
Copy link
Copy Markdown
Contributor Author

mdwn commented May 17, 2023

A comment saying you should specify token or token_file but not both would be great

If you don't mind, let's do that in a follow on to make sure that backporting the assist code isn't wonky due to only the v13 version of this having the comment.

@mdwn mdwn added this pull request to the merge queue May 17, 2023
Merged via the queue into branch/v13 with commit df3dc94 May 17, 2023
@mdwn mdwn deleted the mike.wilson/v13-plugin-bearer-token branch May 17, 2023 15:12
@r0mant r0mant mentioned this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants