Assist - Configuration and usage by jakule · Pull Request #25953 · gravitational/teleport

jakule · 2023-05-09T19:51:09Z

This PR contains Teleport Assist configuration changes - YAML files, Cloud config, and prehog.

Note: YAML configuration will be removed once plugin supports is available in Teleport OSS.

zmb3 · 2023-05-10T14:47:29Z

Does this need to be exported?

r0mant · 2023-05-10T15:08:28Z

Suggested change

return trace.Errorf("failed to read OpenAI API key file: %w", err)

return trace.ConvertSystemError("failed to read OpenAI API key file at path %v: %w", keyPath, err)

r0mant · 2023-05-10T15:09:24Z

Suggested change

OpenAI *OpenAIOptions `yaml:"openai,omitempty"`

// OpenAI is ...

OpenAI *OpenAIOptions `yaml:"openai,omitempty"`

r0mant · 2023-05-10T15:09:30Z

Suggested change

//APITokenPath is the path to a file with OpenAI API key.

// APITokenPath is the path to a file with OpenAI API key.

* Assist - Configuration and usage * Add network config test * Add config test * Run GCI * Address review comments

* Assist - Configuration and usage (#25953) * Assist - Configuration and usage * Add network config test * Add config test * Run GCI * Address review comments * Fix imports

* Assist - Configuration and usage * Add network config test * Add config test * Run GCI * Address review comments

* Assist - API implementation (#25810) * Assist - API implementation * Add Assistant CRUD test * Move assistant API to a separate file. * Rename GRPC methods Fix comments * Address PR comments * Update GRPC API - addressing code review comments * Move assist API to a new GRPC service * Add Assistant RBAC rules to this backport. * Add missing license * Update comment. * Move username and ID out of AssistantMessage (#25964) * Move username and ID out of AssistantMessage #25810 added username and conversation ID to AssistantMessage. They aren't needed inside the message and can be moved out of it. This PR also fixes ` grpc: error while marshaling: proto: Marshal called with nil` in `CreateAssistantMessage`. Note: It's safe to change protobuf numbers as this code hasn't been released or backported yet. * Fix test * make grpc * Assist - Configuration and usage (#25953) * Assist - Configuration and usage * Add network config test * Add config test * Run GCI * Address review comments * Assist - OpenAI library port (#25948) * Assist - OpenAI library port * Add tests * Address code review comments * Added comment * Partial backport of #26058 * Move AI messages to a new file * Prevent blocking on error * Add comments. Fix typo * Assist - Execution web endpoint (#25955) * Assist - Execution web endpoint * Add test Clean up code a bit * Add missing username * Address review comments * Make more implementation shared between Terminal and Command Web Handlers * Address review comments * Address review comments * Fixes after rebase Add comments * Add comments Fix linter * Add TELEPORT to Teleport related environment variable. * Assist - Web endpoints (#26046) * Assist - Web endpoints * GCI * proto rpc * enforce endpoint checks * disable in ui if disallowed by auth * add comment * unwrap stack * Refactor code --------- Co-authored-by: Joel Wejdenstål <jwejdenstal@icloud.com> * [Assist] Fix random user selection (#26183) Currently, after selecting a user for command execution in Teleport Assist the user can randomly change. This PR fixes this behavior. * Add rate limiting to Assist (#26011) * Add rate limiting to Assist * Only rate limit Assist in Cloud * Add a comment to assistantLimiter * Fixes after rebase * Add 'rate-limited' test case to assistant_test * Handle CHAT_MESSAGE_UI in Assist web UI * Add godoc * CHAT_MESSAGE_UI -> CHAT_MESSAGE_ERROR * Run assistant test cases in parallel * Rename `ChatGPT` to `GPT-4` (#26272) * Rename `ChatGPT` to `GPT4` ChatGPT is a user friendly name, but is technically inaccurate. * Apply suggestions from code review Co-authored-by: Reed Loden <reed@goteleport.com> * Lint fix * Additional ChatGPT --> OpenAI GPT-4 fixes --------- Co-authored-by: Reed Loden <reed@goteleport.com> * Fix Assist rate-limiting in Cloud (#26342) When Proxy is separate from Auth, Proxy 'modules' will not contain meaningful data. Instead, one must use ClusterFeatures fetched from the Auth server * Assist UI improvements (#26365) * Update assist warning wording, add link to ToS (#26396) * Always render the portal for the assist title to go into (#26733) * Stop using TokenPath for API key in Assist (#26671) * [Assist] MFA support (#26719) * Initial support for MFA in Assist * UI webauth handler * WebUI - WIP * Run prettier * Perform MFA ceremony only once. * Cleanup JS * Remove hacky WS logic * Add cancel MFA logic * [Assist] Prevent creating messages without conversation (#26797) * Add parallel execution to assist. (#26563) * Add parallel execution to assist. * Extract execution logic to a new function. * Add test * Switch uber to std * Address code review comments * Fix display of Assist command executions with empty output (#27010) * Fix display of Assist executions with empty output * Lint * Nit * Improve display of commands that failed with code * Address lint * [Assist] Allow removing assist conversations (#26788) * [Assist] Allow removing assist conversations * Display landing page after the conversion is removed * Improve styling and add a confirmation dialog * Change the icon opacity to copy the main navigation * Remove unused minus icon * Add missing trace.wrap --------- Co-authored-by: Ryan Clark <ryan.clark@goteleport.com> * Backport fixes * Regenerate go.sum to make the linter happy. * Sync files after rebase * After rebase fixes --------- Co-authored-by: Joel Wejdenstål <jwejdenstal@icloud.com> Co-authored-by: Justinas Stankevičius <justinas@users.noreply.github.com> Co-authored-by: Mike Jensen <jentfoo@users.noreply.github.com> Co-authored-by: Reed Loden <reed@goteleport.com> Co-authored-by: Ryan Clark <ryan.clark@goteleport.com>

jakule force-pushed the jakule/ai-config-port branch from 06bb21d to 74d9701 Compare May 10, 2023 06:38

jakule marked this pull request as ready for review May 10, 2023 06:58

github-actions Bot added the size/md label May 10, 2023

github-actions Bot requested review from gabrielcorado and probakowski May 10, 2023 06:59

jakule assigned justinas and jakule May 10, 2023

jakule requested review from r0mant and zmb3 May 10, 2023 07:01

zmb3 approved these changes May 10, 2023

View reviewed changes

r0mant approved these changes May 10, 2023

View reviewed changes

public-teleport-github-review-bot Bot removed request for gabrielcorado and probakowski May 10, 2023 15:14

jakule added this pull request to the merge queue May 10, 2023

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 10, 2023

jakule added this pull request to the merge queue May 10, 2023

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 10, 2023

jakule added this pull request to the merge queue May 10, 2023

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 10, 2023

jakule added 5 commits May 10, 2023 21:40

Assist - Configuration and usage

2a064b3

Add network config test

03e322e

Add config test

70deb3f

Run GCI

ad5dea2

Address review comments

52a35e7

jakule force-pushed the jakule/ai-config-port branch from d35ed6e to 52a35e7 Compare May 11, 2023 01:41

jakule enabled auto-merge May 11, 2023 01:43

jakule added this pull request to the merge queue May 11, 2023

Merged via the queue into master with commit ae8f2fa May 11, 2023

jakule deleted the jakule/ai-config-port branch May 11, 2023 02:13

jakule added a commit that referenced this pull request May 11, 2023

Assist - Configuration and usage (#25953)

3777449

* Assist - Configuration and usage * Add network config test * Add config test * Run GCI * Address review comments

jakule mentioned this pull request May 11, 2023

[v12] Assist - Configuration and usage #26045

Merged

mdwn pushed a commit that referenced this pull request May 17, 2023

Assist - Configuration and usage (#25953)

e4f569b

* Assist - Configuration and usage * Add network config test * Add config test * Run GCI * Address review comments

mdwn mentioned this pull request May 17, 2023

[v13] Add in plugin bearer token credentials. #26436

Merged

jakule added a commit that referenced this pull request Jun 2, 2023

Assist - Configuration and usage (#25953)

6990a3a

* Assist - Configuration and usage * Add network config test * Add config test * Run GCI * Address review comments

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Assist - Configuration and usage#25953

Assist - Configuration and usage#25953
jakule merged 5 commits intomasterfrom
jakule/ai-config-port

jakule commented May 9, 2023 •

edited

Loading

Uh oh!

zmb3 May 10, 2023

Uh oh!

jakule May 10, 2023

Uh oh!

r0mant May 10, 2023

Uh oh!

r0mant May 10, 2023

Uh oh!

jakule May 10, 2023

Uh oh!

r0mant May 10, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	return trace.Errorf("failed to read OpenAI API key file: %w", err)
	return trace.ConvertSystemError("failed to read OpenAI API key file at path %v: %w", keyPath, err)

	OpenAI *OpenAIOptions `yaml:"openai,omitempty"`
	// OpenAI is ...
	OpenAI *OpenAIOptions `yaml:"openai,omitempty"`

	//APITokenPath is the path to a file with OpenAI API key.
	// APITokenPath is the path to a file with OpenAI API key.

Conversation

jakule commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zmb3 May 10, 2023

Choose a reason for hiding this comment

Uh oh!

jakule May 10, 2023

Choose a reason for hiding this comment

Uh oh!

r0mant May 10, 2023

Choose a reason for hiding this comment

Uh oh!

r0mant May 10, 2023

Choose a reason for hiding this comment

Uh oh!

jakule May 10, 2023

Choose a reason for hiding this comment

Uh oh!

r0mant May 10, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jakule commented May 9, 2023 •

edited

Loading