[v12] Change TestDeleteMFADeviceSync to do per-delete assertions#26408
Merged
codingllama merged 1 commit intobranch/v12from May 17, 2023
Merged
[v12] Change TestDeleteMFADeviceSync to do per-delete assertions#26408codingllama merged 1 commit intobranch/v12from
codingllama merged 1 commit intobranch/v12from
Conversation
* Change TestDeleteMFADeviceSync to do per-delete assertions * nit: Change minDevices to `1` for readability
codingllama
commented
May 16, 2023
|
|
||
| username := "llama@goteleport.com" | ||
| _, _, err := CreateUserAndRole(srv.Auth(), username, []string{username}) | ||
| _, _, err := CreateUserAndRole(authServer, username, []string{username}) |
Contributor
Author
There was a problem hiding this comment.
Conflict was in this line, CreateUserAndRole has an extra argument on master/branch/v13.
zmb3
approved these changes
May 16, 2023
kimlisa
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #26311 to branch/v12
Change TestDeleteMFADeviceSync to assert inside the t.Run loop and remove
trailing assertions.
#26190