Change TestDeleteMFADeviceSync to do per-delete assertions#26311
Merged
codingllama merged 2 commits intomasterfrom May 16, 2023
Merged
Change TestDeleteMFADeviceSync to do per-delete assertions#26311codingllama merged 2 commits intomasterfrom
codingllama merged 2 commits intomasterfrom
Conversation
Contributor
Author
|
This seems to cut down flakiness for me, although I can't say I'm sure what was the problem with the original test. Still, this style is a bit more usual, so not a terrible change. |
codingllama
force-pushed
the
codingllama/deletesync-flaky
branch
from
ce33b15 to
2f35868
Compare
kimlisa
approved these changes
May 16, 2023
Contributor
kimlisa
left a comment
kimlisa
left a comment
There was a problem hiding this comment.
thanks for the fix, i tested it out with and without change and it seemed to have rid the issue
zmb3
approved these changes
May 16, 2023
public-teleport-github-review-bot
Bot
removed request for
fspmarshall and
xacrimon
|
@codingllama See the table below for backport results.
|
codingllama
added a commit
that referenced
this pull request
May 16, 2023
* Change TestDeleteMFADeviceSync to do per-delete assertions * nit: Change minDevices to `1` for readability
codingllama
added a commit
that referenced
this pull request
May 16, 2023
* Change TestDeleteMFADeviceSync to do per-delete assertions * nit: Change minDevices to `1` for readability
codingllama
added a commit
that referenced
this pull request
May 17, 2023
) * Change TestDeleteMFADeviceSync to do per-delete assertions (#26311) * Change TestDeleteMFADeviceSync to do per-delete assertions * nit: Change minDevices to `1` for readability * Add assert import
codingllama
added a commit
that referenced
this pull request
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change TestDeleteMFADeviceSync to assert inside the t.Run loop and remove trailing assertions.
#26190