[v12] Update version in tsh.app Info.plist#26318
Merged
camscale merged 1 commit intobranch/v12from May 16, 2023
Merged
Conversation
Update the version in tsh.app (tsh and tshdev) `Info.plist` files when `make version` (`make update-version`) is run. If the version number has any semver prerelease tags, then the tsh version number will be set to "1.0", as those tags are not valid in the CFBundleShortVersionString or CFBundleVersion fields. For a release without a semver tag, the value will be set. This will update the CFBundleVersion and CFBundleShortVersionString fields of the `Info.plist` file. This commit contains re-written plist files as they get reindented by the tool, the CFBundleVersion becomes "1.0" (was "1") and one empty element is shortened to the empty-element form. Link: https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleversion Link: https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleshortversionstring
AntonAM
approved these changes
May 16, 2023
codingllama
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #25616 to branch/v12
Update the version in tsh.app (tsh and tshdev)
Info.plistfiles whenmake version(make update-version) is run. If the version number hasany semver prerelease tags, then the tsh version number will be set to
"1.0", as those tags are not valid in the CFBundleShortVersionString or
CFBundleVersion fields. For a release without a semver tag, the value
will be set.
This will update the CFBundleVersion and CFBundleShortVersionString
fields of the
Info.plistfile.This commit contains re-written plist files as they get reindented by
the tool, the CFBundleVersion becomes "1.0" (was "1") and one empty
element is shortened to the empty-element form.
Issue: #25085
Link: https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleversion
Link: https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleshortversionstring
Backport: #25616