Conversation
camscale
force-pushed
the
camh/tsh-version
branch
3 times, most recently
from
83c2c03 to
4b4f38b
Compare
Contributor
Author
|
I had thought that |
Contributor
Author
|
Ok, I've updated to use |
codingllama
reviewed
May 4, 2023
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Thanks for addressing #25085, Cam. It was on my radar as well, but I wouldn't get to it very quickly.
Contributor
|
Added backport tags for all active releases. |
camscale
force-pushed
the
camh/tsh-version
branch
2 times, most recently
from
0a49775 to
8998b38
Compare
Contributor
Author
|
@codingllama @r0mant @AntonAM I've revved this PR to now use a Go program to update the plist files. PTAL |
codingllama
reviewed
May 11, 2023
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Thanks for the version update program, looks much more solid than before.
codingllama
reviewed
May 11, 2023
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Thanks for the version update program, looks much more solid than before.
codingllama
approved these changes
May 12, 2023
Contributor
Author
codingllama
approved these changes
May 15, 2023
AntonAM
approved these changes
May 15, 2023
Update the version in tsh.app (tsh and tshdev) `Info.plist` files when `make version` (`make update-version`) is run. If the version number has any semver prerelease tags, then the tsh version number will be set to "1.0", as those tags are not valid in the CFBundleShortVersionString or CFBundleVersion fields. For a release without a semver tag, the value will be set. This will update the CFBundleVersion and CFBundleShortVersionString fields of the `Info.plist` file. This commit contains re-written plist files as they get reindented by the tool, the CFBundleVersion becomes "1.0" (was "1") and one empty element is shortened to the empty-element form. Link: https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleversion Link: https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleshortversionstring
camscale
force-pushed
the
camh/tsh-version
branch
from
886eb6d to
c64193b
Compare
This was referenced May 15, 2023
Contributor
Author
|
Remove v10 backport label as that is no longer a supported release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the version in tsh.app (tsh and tshdev)
Info.plistfiles whenmake version(make update-version) is run. If the version number hasany semver prerelease tags, then the tsh version number will be set to
"1.0", as those tags are not valid in the CFBundleShortVersionString
field. For a release without a semver tag, the value will be set.
Issue: #25085
Link: https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleshortversionstring