athena audit logs - single consumer on auth#25639
Merged
tobiaszheller merged 1 commit intomasterfrom May 15, 2023
Merged
Conversation
Contributor
Author
tobiaszheller
changed the title
camscale
reviewed
May 8, 2023
tobiaszheller
commented
May 9, 2023
rosstimothy
reviewed
May 10, 2023
Contributor
Author
|
@rosstimothy @camscale @timothyb89 friendly ping for review |
rosstimothy
approved these changes
May 12, 2023
camscale
approved these changes
May 15, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from timothyb89
tobiaszheller
force-pushed
the
tobiaszheller/auditevents-athena-single-auth-consumer-v3
branch
from
bba942b to
05424c4
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
tobiaszheller
deleted the
tobiaszheller/auditevents-athena-single-auth-consumer-v3
branch
|
@tobiaszheller See the table below for backport results.
|
|
@tobiaszheller See the table below for backport results.
|
|
@tobiaszheller See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Jul 27, 2023
rosstimothy
added a commit
that referenced
this pull request
Jul 27, 2023
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
* Add configuration with optional timeout to AcquireLock (#24559) * Add configuration with optional timeout to AcquireLock * rename to RetryInterval * backport RunWhileLocked changes from #25639 * Hold Auth init lock for the duration of initialization (#29593) Auth now uses `RunWhileLocked` instead of `AcquireLock` to ensure that the initialization lock is held until the bootstrapping process is completed. Prior, Auth only held the lock for 30s which could allow multiple Auths to attempt bootstrapping simultaneously. Initialization should complete prior to 30s in most cases, but it is not guarateed, especially on first boot when CAs are being generated and a large data migration may be needed. --------- Co-authored-by: Tobiasz Heller <14020794+tobiaszheller@users.noreply.github.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
* Add configuration with optional timeout to AcquireLock (#24559) * Add configuration with optional timeout to AcquireLock * rename to RetryInterval * backport RunWhileLocked changes from #25639 * Hold Auth init lock for the duration of initialization (#29593) Auth now uses `RunWhileLocked` instead of `AcquireLock` to ensure that the initialization lock is held until the bootstrapping process is completed. Prior, Auth only held the lock for 30s which could allow multiple Auths to attempt bootstrapping simultaneously. Initialization should complete prior to 30s in most cases, but it is not guarateed, especially on first boot when CAs are being generated and a large data migration may be needed. --------- Co-authored-by: Tobiasz Heller <14020794+tobiaszheller@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/gravitational/teleport.e/issues/894
RFD: https://github.com/gravitational/teleport/blob/master/rfd/0118-scalable-audit-logs.md
This PR enable running consumer on single auth instance using object locking.
in 7270f8b
there are changes to runWhileLocked: passing config and releasing lock with ctx.background.
Fixes #15210