Add configuration with optional timeout to AcquireLock#24559
Merged
tobiaszheller merged 2 commits intomasterfrom Apr 14, 2023
Merged
Add configuration with optional timeout to AcquireLock#24559tobiaszheller merged 2 commits intomasterfrom
tobiaszheller merged 2 commits intomasterfrom
Conversation
espadolini
reviewed
Apr 14, 2023
espadolini
approved these changes
Apr 14, 2023
tigrato
approved these changes
Apr 14, 2023
public-teleport-github-review-bot
Bot
removed request for
atburke,
probakowski and
russjones
rosstimothy
pushed a commit
that referenced
this pull request
Jul 27, 2023
* Add configuration with optional timeout to AcquireLock * rename to RetryInterval
rosstimothy
pushed a commit
that referenced
this pull request
Jul 27, 2023
* Add configuration with optional timeout to AcquireLock * rename to RetryInterval
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
* Add configuration with optional timeout to AcquireLock (#24559) * Add configuration with optional timeout to AcquireLock * rename to RetryInterval * backport RunWhileLocked changes from #25639 * Hold Auth init lock for the duration of initialization (#29593) Auth now uses `RunWhileLocked` instead of `AcquireLock` to ensure that the initialization lock is held until the bootstrapping process is completed. Prior, Auth only held the lock for 30s which could allow multiple Auths to attempt bootstrapping simultaneously. Initialization should complete prior to 30s in most cases, but it is not guarateed, especially on first boot when CAs are being generated and a large data migration may be needed. --------- Co-authored-by: Tobiasz Heller <14020794+tobiaszheller@users.noreply.github.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 28, 2023
* Add configuration with optional timeout to AcquireLock (#24559) * Add configuration with optional timeout to AcquireLock * rename to RetryInterval * backport RunWhileLocked changes from #25639 * Hold Auth init lock for the duration of initialization (#29593) Auth now uses `RunWhileLocked` instead of `AcquireLock` to ensure that the initialization lock is held until the bootstrapping process is completed. Prior, Auth only held the lock for 30s which could allow multiple Auths to attempt bootstrapping simultaneously. Initialization should complete prior to 30s in most cases, but it is not guarateed, especially on first boot when CAs are being generated and a large data migration may be needed. --------- Co-authored-by: Tobiasz Heller <14020794+tobiaszheller@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds option to configure retry timeout on acquiring lock. I need it in other PR, to avoid using default 250ms.