Table-related improvements #25333
Merged
gzdunek merged 6 commits intogzdunek/theme-updatesfrom May 4, 2023
Merged
Conversation
ibeckermayer
approved these changes
Apr 28, 2023
Contributor
ibeckermayer
left a comment
ibeckermayer
left a comment
There was a problem hiding this comment.
Appreciate the attention to detail.
Reminder to check the e-ref before merging.
ryanclark
approved these changes
May 2, 2023
gzdunek
added a commit
that referenced
this pull request
May 4, 2023
* Make pagination icons a little more visible * Use different color for `tr` border * Use `opacity: 1` for placeholders * Include `borderRadius` in `StyledPanel` to fix rounded corners in Connect custom tables * Use `colors.text.primary` for items in `MenuLogin` * Adjust Connect theme to the updated dark theme * Remove unused component * Update snapshots * Remove `surfaceSecondary` and `sunkenSecondary` colors * Remove unneeded `inherit` * Do not hardcode bg color in `TextArea` * Expand comment * Simplify the look of top bar elements * Remove unused component * Remove `text.contrast` * Use the same dark theme for WebUI and Connect * Revert "Make pagination icons a little more visible" This reverts commit 1fe1d7b. * Add shadow for the tabs * Post-merge fixes * Do not use Arial on custom buttons * Revert snapshot changes * Fix colors in `ActionPicker` * Apply hover styles directly on `SearchBar` input * Use white color for "Database Connection" header * Add shadow directly to `StyledTabs` * Run prettier * Update e * Add some top padding to the terminal * Review fixes * Move SearchBar hover to the Flex element * Table-related improvements (#25333) * Use a better icon for the reverse tunnel cell * Use `ButtonIcon` for pagination icons * Fix rendering table border on Safari * Manually add a visual separator between the table and the element below it * Add bottom padding to resource tables in Connect * Update snapshots * Update snapshots * Revert e
gzdunek
added a commit
that referenced
this pull request
May 4, 2023
* Theme fixes (#24883) * Make pagination icons a little more visible * Use different color for `tr` border * Use `opacity: 1` for placeholders * Include `borderRadius` in `StyledPanel` to fix rounded corners in Connect custom tables * Use `colors.text.primary` for items in `MenuLogin` * Adjust Connect theme to the updated dark theme * Remove unused component * Update snapshots * Remove `surfaceSecondary` and `sunkenSecondary` colors * Remove unneeded `inherit` * Do not hardcode bg color in `TextArea` * Expand comment * Simplify the look of top bar elements * Remove unused component * Remove `text.contrast` * Use the same dark theme for WebUI and Connect * Revert "Make pagination icons a little more visible" This reverts commit 1fe1d7b. * Add shadow for the tabs * Post-merge fixes * Do not use Arial on custom buttons * Revert snapshot changes * Fix colors in `ActionPicker` * Apply hover styles directly on `SearchBar` input * Use white color for "Database Connection" header * Add shadow directly to `StyledTabs` * Run prettier * Update e * Add some top padding to the terminal * Review fixes * Move SearchBar hover to the Flex element * Table-related improvements (#25333) * Use a better icon for the reverse tunnel cell * Use `ButtonIcon` for pagination icons * Fix rendering table border on Safari * Manually add a visual separator between the table and the element below it * Add bottom padding to resource tables in Connect * Update snapshots * Update snapshots * Revert e (cherry picked from commit 1870c80) * Update `Session.story.test.tsx.snap`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e counterpart https://github.com/gravitational/teleport.e/pull/1244
Here are a few table-related fixes:
ButtonIcon(it has proper colors)⟵ tunnel← tunneltdelement instead oftr- Safari incorrectly renders semi-transparent color when table borders are collapsed (more info in a comment)trelement. It was fine when the table had an element below it, but if not, we just rendered a weird-looking line:(I'm going to merge this PR into
gzdunek/theme-updates, so I'll have less work with backports)