[v13] Add full IP pinning enforcement#25053
Merged
AntonAM merged 1 commit intobranch/v13from Apr 24, 2023
Merged
Conversation
tigrato
approved these changes
Apr 24, 2023
077ed0c to
d67acc3
Compare
strideynet
approved these changes
Apr 24, 2023
* Add full IP pinning enforcement We're adding IP pinning check to `authorizer.Authorize` which is used for every call, so now all communications with teleport should enforce IP pinning. Also making sure we always provide login IP for user certificate creation and correct client IP propagation everywhere. * Add integration test for App IP pinning. * Fix wording Co-authored-by: Tiago Silva <tiago.silva@goteleport.com> * Wrap error Co-authored-by: Tiago Silva <tiago.silva@goteleport.com> * Add godocs * Clone TLS config * Improve proxyHeaderSigner usage * Wider use proxyHeaderDialer and remove adhoc writing of singed header * Add helper function TLSDial * Use proxyHeader dialer in authConnect * Simplify tlsConfig manipulation Co-authored-by: Przemko Robakowski <przemko.robakowski@goteleport.com> * Remove redundant channels processing in TLSDial * Reduce nesting * Update generated protobufs * Remove ignoring of bad IP on signed PROXY header generation * Provide logger to CheckIPPinning function --------- Co-authored-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: Przemko Robakowski <przemko.robakowski@goteleport.com>
d67acc3 to
f795b83
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #24743 to branch/v13