Merged
Conversation
AntonAM
force-pushed
the
anton/full-ip-pinning-enforcement
branch
8 times, most recently
from
dd0a122 to
76d4710
Compare
github-actions
Bot
added
application-access
database-access
AntonAM
force-pushed
the
anton/full-ip-pinning-enforcement
branch
from
76d4710 to
365941f
Compare
tigrato
reviewed
Apr 20, 2023
AntonAM
force-pushed
the
anton/full-ip-pinning-enforcement
branch
3 times, most recently
from
f0598b3 to
1a312e2
Compare
probakowski
reviewed
Apr 20, 2023
Contributor
probakowski
left a comment
probakowski
left a comment
There was a problem hiding this comment.
Overall looks ok, few suggestions
We're adding IP pinning check to `authorizer.Authorize` which is used for every call, so now all communications with teleport should enforce IP pinning. Also making sure we always provide login IP for user certificate creation and correct client IP propagation everywhere.
Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
Co-authored-by: Tiago Silva <tiago.silva@goteleport.com>
Co-authored-by: Przemko Robakowski <przemko.robakowski@goteleport.com>
AntonAM
force-pushed
the
anton/full-ip-pinning-enforcement
branch
from
039532f to
9be1e22
Compare
probakowski
approved these changes
Apr 21, 2023
tigrato
approved these changes
Apr 22, 2023
public-teleport-github-review-bot
Bot
removed request for
GavinFrazar,
rosstimothy and
strideynet
AntonAM
force-pushed
the
anton/full-ip-pinning-enforcement
branch
from
9e9b7b5 to
f5a693e
Compare
AntonAM
added a commit
that referenced
this pull request
Apr 24, 2023
* Add full IP pinning enforcement We're adding IP pinning check to `authorizer.Authorize` which is used for every call, so now all communications with teleport should enforce IP pinning. Also making sure we always provide login IP for user certificate creation and correct client IP propagation everywhere. * Add integration test for App IP pinning. * Fix wording Co-authored-by: Tiago Silva <tiago.silva@goteleport.com> * Wrap error Co-authored-by: Tiago Silva <tiago.silva@goteleport.com> * Add godocs * Clone TLS config * Improve proxyHeaderSigner usage * Wider use proxyHeaderDialer and remove adhoc writing of singed header * Add helper function TLSDial * Use proxyHeader dialer in authConnect * Simplify tlsConfig manipulation Co-authored-by: Przemko Robakowski <przemko.robakowski@goteleport.com> * Remove redundant channels processing in TLSDial * Reduce nesting * Update generated protobufs * Remove ignoring of bad IP on signed PROXY header generation * Provide logger to CheckIPPinning function --------- Co-authored-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: Przemko Robakowski <przemko.robakowski@goteleport.com>
webvictim
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Add full IP pinning enforcement We're adding IP pinning check to `authorizer.Authorize` which is used for every call, so now all communications with teleport should enforce IP pinning. Also making sure we always provide login IP for user certificate creation and correct client IP propagation everywhere. * Add integration test for App IP pinning. * Fix wording * Wrap error * Add godocs * Clone TLS config * Improve proxyHeaderSigner usage * Wider use proxyHeaderDialer and remove adhoc writing of singed header * Add helper function TLSDial * Use proxyHeader dialer in authConnect * Simplify tlsConfig manipulation * Remove redundant channels processing in TLSDial * Reduce nesting * Update generated protobufs * Remove ignoring of bad IP on signed PROXY header generation * Provide logger to CheckIPPinning function --------- Co-authored-by: Tiago Silva <tiago.silva@goteleport.com> Co-authored-by: Przemko Robakowski <przemko.robakowski@goteleport.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're adding IP pinning check to
authorizer.Authorizewhich is used for every call, so now all communications with teleport should enforce IP pinning. Also making sure we always provide login IP for user certificate creation, with single use certificates always pinned (if it's enterprise), and correct client IP propagation everywhere.