fix reverse tunnel cannot connect if proxy address contains https#24871
Merged
fix reverse tunnel cannot connect if proxy address contains https#24871
Conversation
smallinsky
reviewed
Apr 20, 2023
greedy52
force-pushed
the
STeve/24796_fix_proxy_with_https
branch
from
b7cbc8f to
7750ed9
Compare
smallinsky
approved these changes
Apr 21, 2023
Tener
approved these changes
Apr 21, 2023
public-teleport-github-review-bot
Bot
removed request for
fspmarshall and
tobiaszheller
Contributor
|
@greedy52 should we backport this to v13? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24796
Related change:
#23866
Prior to the above change, TLS routing dialer was forcing "tcp" network when "https" is passed in:
teleport/lib/utils/proxy/proxy.go
Line 154 in eec5803
Instead re-applying the same forcing-network-tcp fix, this change tries to make sure "tcp" is passed in.