Skip to content

TLS routing behind LB support for Auth, SSH, Reverse tunnel#23866

Merged
greedy52 merged 32 commits intomasterfrom
STeve/21870_ssh_auth_reversetunnel
Apr 14, 2023
Merged

TLS routing behind LB support for Auth, SSH, Reverse tunnel#23866
greedy52 merged 32 commits intomasterfrom
STeve/21870_ssh_auth_reversetunnel

Conversation

@greedy52
Copy link
Copy Markdown
Contributor

@greedy52 greedy52 commented Mar 30, 2023 •
edited
Loading

Part of:

No UX change.

Tested:

  • Agent connect auth through tunnel dialer
  • Reverse tunnel to remote cluster
  • tsh login
  • tsh db connect --cluster
  • tsh ssh xxx@xxx, tsh config + ssh
  • tsh aws s3 ls
  • tcl
  • tracing client

@greedy52 greedy52 self-assigned this Mar 30, 2023
@github-advanced-security
Copy link
Copy Markdown

github-advanced-security AI commented Mar 30, 2023

You have successfully added a new Trivy configuration .github/workflows/trivy.yaml:trivy. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@greedy52 greedy52 force-pushed the STeve/21870_ssh_auth_reversetunnel branch 2 times, most recently from 5c2dab9 to 7517b95 Compare March 31, 2023 02:36
@greedy52 greedy52 force-pushed the STeve/21870_ssh_auth_reversetunnel branch from 7517b95 to a5de0d9 Compare March 31, 2023 03:02
@greedy52 greedy52 requested a review from smallinsky April 1, 2023 20:54
@greedy52 greedy52 marked this pull request as ready for review April 2, 2023 18:32
@github-actions github-actions Bot added size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Apr 2, 2023
@github-actions github-actions Bot requested review from AntonAM and espadolini April 2, 2023 18:33
@greedy52 greedy52 requested review from Tener and gabrielcorado April 2, 2023 18:33
@greedy52 greedy52 force-pushed the STeve/21870_ssh_auth_reversetunnel branch from b75125a to 922fc8b Compare April 6, 2023 19:08
@greedy52
Copy link
Copy Markdown
Contributor Author

greedy52 commented Apr 10, 2023

PTAL @smallinsky @espadolini thanks!

@greedy52 greedy52 mentioned this pull request Apr 10, 2023
Merged
smallinsky
smallinsky reviewed Apr 12, 2023
View reviewed changes
Comment thread api/client/alpn_conn_upgrade.go Outdated
Comment thread api/client/alpn_conn_upgrade.go Outdated
Comment thread lib/web/conn_upgrade_test.go
Comment thread lib/web/conn_upgrade.go Outdated
Comment thread lib/web/conn_upgrade.go
Comment thread lib/client/api.go Outdated
Comment thread api/client/contextdialer.go
@greedy52 greedy52 requested a review from smallinsky April 12, 2023 18:47
smallinsky
smallinsky reviewed Apr 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@smallinsky smallinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we are almost here.
Want to clarify the auth dial ping upgrade in case of protocols like teleport-auth@and reverse tunnel v2

Comment thread api/client/client.go Outdated
Comment thread api/client/client.go Outdated
Comment thread api/client/client.go Outdated
Comment thread api/client/alpn.go
Comment thread api/client/contextdialer.go
Comment thread api/client/proxy/client.go Outdated
@smallinsky smallinsky self-requested a review April 13, 2023 16:13
smallinsky
smallinsky approved these changes Apr 14, 2023
View reviewed changes
Comment thread api/client/alpn.go
Comment thread api/client/alpn.go Outdated
Comment thread lib/reversetunnel/agentpool.go Outdated
smallinsky
smallinsky reviewed Apr 14, 2023
View reviewed changes
Comment thread lib/client/client.go Outdated
gabrielcorado
gabrielcorado approved these changes Apr 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@gabrielcorado gabrielcorado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread lib/client/client.go Outdated
Comment thread integration/proxy/proxy_helpers.go
@greedy52 greedy52 enabled auto-merge April 14, 2023 19:07
@greedy52 greedy52 added this pull request to the merge queue Apr 14, 2023
Merged via the queue into master with commit b1941aa Apr 14, 2023
@greedy52 greedy52 deleted the STeve/21870_ssh_auth_reversetunnel branch April 14, 2023 19:38
@Tener Tener mentioned this pull request Apr 19, 2023
Closed
@greedy52 greedy52 mentioned this pull request Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smallinsky smallinsky smallinsky approved these changes

@gabrielcorado gabrielcorado gabrielcorado approved these changes

@AntonAM AntonAM Awaiting requested review from AntonAM

@espadolini espadolini Awaiting requested review from espadolini

@Tener Tener Awaiting requested review from Tener

Assignees

@greedy52 greedy52

Labels

size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@greedy52 @github-advanced-security @espadolini @gabrielcorado @smallinsky