[v12] Tweak protogen to not change protos from cloud (#24688)#24739
Merged
espadolini merged 1 commit intobranch/v12from Apr 18, 2023
Merged
[v12] Tweak protogen to not change protos from cloud (#24688)#24739espadolini merged 1 commit intobranch/v12from
espadolini merged 1 commit intobranch/v12from
Conversation
* Tweak protogen to not change protos from cloud * Use strategy: all whenever possible * Sync protos from gravitational/cloud
codingllama
approved these changes
Apr 18, 2023
| // UIDiscoverIntegrationAWSOIDCConnectEvent is emitted when a user is finished with the step | ||
| // that asks user to setup aws integration or select from a list of existing | ||
| // aws integrations. | ||
| message UIDiscoverIntegrationAWSOIDCConnectEvent { |
Contributor
There was a problem hiding this comment.
I suppose you want those here, so we are piggybacking on the backport to bring the protos as well?
(No objections, just clarifying.)
Contributor
Author
There was a problem hiding this comment.
I just updated to the latest version from the tip of gravitational/cloud:master, I figured it was harmless enough.
rosstimothy
approved these changes
Apr 18, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #24688 to branch/v12