Tweak protogen to not change protos from cloud#24688
Merged
espadolini merged 2 commits intomasterfrom Apr 18, 2023
Merged
Conversation
codingllama
approved these changes
Apr 18, 2023
rosstimothy
approved these changes
Apr 18, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from tobiaszheller
|
@espadolini See the table below for backport results.
|
espadolini
added a commit
that referenced
this pull request
Apr 18, 2023
* Tweak protogen to not change protos from cloud * Use strategy: all whenever possible * Sync protos from gravitational/cloud
espadolini
added a commit
that referenced
this pull request
Apr 18, 2023
* Tweak protogen to not change protos from cloud * Use strategy: all whenever possible * Sync protos from gravitational/cloud
espadolini
added a commit
that referenced
this pull request
Apr 18, 2023
espadolini
added a commit
that referenced
this pull request
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tweaks the protogen for prehog protos so that we don't need any change when copying the protos over from the tip of
gravitational/cloud.In addition, it changes
genproto.shto list explicit exceptions to theprotoc-gen-go+grpcgeneration rather than generating everything with gogoproto just to overwrite it.The change to
strategy: all(from the default ofstrategy: directory) doesn't affect codegen but improves generation speed a bit - it can't be used withprotoc-gen-gogofast, however.Paired with gravitational/cloud#4177.