Added flag to gh-trigger-workflow tool to wait for pre-existing runs#24696
Merged
Added flag to gh-trigger-workflow tool to wait for pre-existing runs#24696
gh-trigger-workflow tool to wait for pre-existing runs#24696Conversation
fheinecke
force-pushed
the
fred/migration-test-tag-6
branch
from
bdb1a9b to
041702b
Compare
zmb3
reviewed
Apr 17, 2023
hugoShaka
approved these changes
Apr 17, 2023
zmb3
reviewed
Apr 17, 2023
zmb3
reviewed
Apr 17, 2023
r0mant
approved these changes
Apr 17, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from fspmarshall
zmb3
reviewed
Apr 17, 2023
| } | ||
|
|
||
| func waitForActiveWorkflowRuns(ctx context.Context, gh *ghapi.Client, args args) error { | ||
| // If there are runs lasting longer than this then there is a probably a much larger problem at play |
Collaborator
There was a problem hiding this comment.
What does this refer to in this comment?
Contributor
Author
There was a problem hiding this comment.
Good catch - I abstracted something and forgot to move the comment. See https://github.com/gravitational/teleport/pull/24696/files#diff-bed36c0295aefb2dee9b838f0a4f0227c2304aedb115b0c8c79dd071b0a6b0fcR184-R185 for an update
zmb3
approved these changes
Apr 17, 2023
Contributor
Author
|
Updated all instances of |
fheinecke
added a commit
that referenced
this pull request
Apr 19, 2023
#24696) * Added flag to `gh-trigger-workflow tool` to wait for pre-existing runs * Addressed PR comments * workflowId -> workflowID * Id -> ID
fheinecke
added a commit
that referenced
this pull request
Apr 19, 2023
* Increase GHA build timeout (#22926) Our ARM64 build fails quite frequently due to 30 minutes timeout. This PR increases the build timeout to one hour. * Migrate publishing of new APT and YUM repos to GHA (#24350) * Deleted OPRT from this repo * Migrated dronegen to call gha workflow * Removed dead pipelines * Removed unused function to appease linter * Accounted for private repo promotions * Updated to use package name filter * Accounted for teleport-ent-updater publishing * Added missing `mkdir` call when determining if a release is a pre-release. (#24634) * Added missing mkdir call * Updated to calculate dirname at dronegen time * Removed "workflow-tag" argument from OPRT GHA call (#24637) * Flipped environment logic for OS package promotion (#24639) * Fixed OPRT migration issues (#24655) * Fixed OPRT migration issues * Removed package-to-test from unsupported teleport-ent-updater package * Added flag to `gh-trigger-workflow` tool to wait for pre-existing runs (#24696) * Added flag to `gh-trigger-workflow tool` to wait for pre-existing runs * Addressed PR comments * workflowId -> workflowID * Id -> ID * Updated promotion pipelines to publish OS packages in series (#24753) * Removed pipeline * Removed teleport-ent-updater deployment --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
fheinecke
added a commit
that referenced
this pull request
Apr 19, 2023
* Increase GHA build timeout (#22926) Our ARM64 build fails quite frequently due to 30 minutes timeout. This PR increases the build timeout to one hour. * Migrate publishing of new APT and YUM repos to GHA (#24350) * Deleted OPRT from this repo * Migrated dronegen to call gha workflow * Removed dead pipelines * Removed unused function to appease linter * Accounted for private repo promotions * Updated to use package name filter * Accounted for teleport-ent-updater publishing * Added missing `mkdir` call when determining if a release is a pre-release. (#24634) * Added missing mkdir call * Updated to calculate dirname at dronegen time * Removed "workflow-tag" argument from OPRT GHA call (#24637) * Flipped environment logic for OS package promotion (#24639) * Fixed OPRT migration issues (#24655) * Fixed OPRT migration issues * Removed package-to-test from unsupported teleport-ent-updater package * Added flag to `gh-trigger-workflow` tool to wait for pre-existing runs (#24696) * Added flag to `gh-trigger-workflow tool` to wait for pre-existing runs * Addressed PR comments * workflowId -> workflowID * Id -> ID * Updated promotion pipelines to publish OS packages in series (#24753) * Removed pipeline * Removed teleport-ent-updater deployment --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
fheinecke
added a commit
that referenced
this pull request
Apr 20, 2023
* Increase GHA build timeout (#22926) Our ARM64 build fails quite frequently due to 30 minutes timeout. This PR increases the build timeout to one hour. * Migrate publishing of new APT and YUM repos to GHA (#24350) * Deleted OPRT from this repo * Migrated dronegen to call gha workflow * Removed dead pipelines * Removed unused function to appease linter * Accounted for private repo promotions * Updated to use package name filter * Accounted for teleport-ent-updater publishing * Added missing `mkdir` call when determining if a release is a pre-release. (#24634) * Added missing mkdir call * Updated to calculate dirname at dronegen time * Removed "workflow-tag" argument from OPRT GHA call (#24637) * Flipped environment logic for OS package promotion (#24639) * Fixed OPRT migration issues (#24655) * Fixed OPRT migration issues * Removed package-to-test from unsupported teleport-ent-updater package * Added flag to `gh-trigger-workflow` tool to wait for pre-existing runs (#24696) * Added flag to `gh-trigger-workflow tool` to wait for pre-existing runs * Addressed PR comments * workflowId -> workflowID * Id -> ID * Updated promotion pipelines to publish OS packages in series (#24753) * Removed pipeline * Removed teleport-ent-updater deployment --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
fheinecke
added a commit
that referenced
this pull request
Apr 20, 2023
* OS packaging and auto updates backport - v12 (#24781) * Increase GHA build timeout (#22926) Our ARM64 build fails quite frequently due to 30 minutes timeout. This PR increases the build timeout to one hour. * Migrate publishing of new APT and YUM repos to GHA (#24350) * Deleted OPRT from this repo * Migrated dronegen to call gha workflow * Removed dead pipelines * Removed unused function to appease linter * Accounted for private repo promotions * Updated to use package name filter * Accounted for teleport-ent-updater publishing * Added missing `mkdir` call when determining if a release is a pre-release. (#24634) * Added missing mkdir call * Updated to calculate dirname at dronegen time * Removed "workflow-tag" argument from OPRT GHA call (#24637) * Flipped environment logic for OS package promotion (#24639) * Fixed OPRT migration issues (#24655) * Fixed OPRT migration issues * Removed package-to-test from unsupported teleport-ent-updater package * Added flag to `gh-trigger-workflow` tool to wait for pre-existing runs (#24696) * Added flag to `gh-trigger-workflow tool` to wait for pre-existing runs * Addressed PR comments * workflowId -> workflowID * Id -> ID * Updated promotion pipelines to publish OS packages in series (#24753) * Removed pipeline * Removed teleport-ent-updater deployment --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com> * Removed accidental backport of *-teleport-oci-distroless-images --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
r0mant
pushed a commit
that referenced
this pull request
Apr 20, 2023
* OS packaging and auto updates backport - v12 (#24781) * Increase GHA build timeout (#22926) Our ARM64 build fails quite frequently due to 30 minutes timeout. This PR increases the build timeout to one hour. * Migrate publishing of new APT and YUM repos to GHA (#24350) * Deleted OPRT from this repo * Migrated dronegen to call gha workflow * Removed dead pipelines * Removed unused function to appease linter * Accounted for private repo promotions * Updated to use package name filter * Accounted for teleport-ent-updater publishing * Added missing `mkdir` call when determining if a release is a pre-release. (#24634) * Added missing mkdir call * Updated to calculate dirname at dronegen time * Removed "workflow-tag" argument from OPRT GHA call (#24637) * Flipped environment logic for OS package promotion (#24639) * Fixed OPRT migration issues (#24655) * Fixed OPRT migration issues * Removed package-to-test from unsupported teleport-ent-updater package * Added flag to `gh-trigger-workflow` tool to wait for pre-existing runs (#24696) * Added flag to `gh-trigger-workflow tool` to wait for pre-existing runs * Addressed PR comments * workflowId -> workflowID * Id -> ID * Updated promotion pipelines to publish OS packages in series (#24753) * Removed pipeline * Removed teleport-ent-updater deployment --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com> * Resigned drone.yml --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
-series-runflag to thegh-trigger-workflowtool that causes the tool to wait for any incomplete runs for the workflow to complete (whether they succeed or fail) before triggering the new workflow run. This prevents run cancellation/clobbering when multiple workflow runs are triggered for the same git ref with a concurrency limit set.