Added missing mkdir call when determining if a release is a pre-release.#24634
Merged
Added missing mkdir call when determining if a release is a pre-release.#24634
mkdir call when determining if a release is a pre-release.#24634Conversation
fheinecke
force-pushed
the
fred/migration-test-tag-2
branch
from
c21dc5d to
cce9450
Compare
tcsc
approved these changes
Apr 15, 2023
Contributor
tcsc
left a comment
tcsc
left a comment
There was a problem hiding this comment.
Approved. You could do the dirname equivalent in Go at generation time, but that's not enough for me to reject the PR
Contributor
Author
|
Good point - updated |
tigrato
approved these changes
Apr 15, 2023
russjones
approved these changes
Apr 15, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from rosstimothy
r0mant
approved these changes
Apr 15, 2023
fheinecke
added a commit
that referenced
this pull request
Apr 19, 2023
…ease. (#24634) * Added missing mkdir call * Updated to calculate dirname at dronegen time
fheinecke
added a commit
that referenced
this pull request
Apr 19, 2023
* Increase GHA build timeout (#22926) Our ARM64 build fails quite frequently due to 30 minutes timeout. This PR increases the build timeout to one hour. * Migrate publishing of new APT and YUM repos to GHA (#24350) * Deleted OPRT from this repo * Migrated dronegen to call gha workflow * Removed dead pipelines * Removed unused function to appease linter * Accounted for private repo promotions * Updated to use package name filter * Accounted for teleport-ent-updater publishing * Added missing `mkdir` call when determining if a release is a pre-release. (#24634) * Added missing mkdir call * Updated to calculate dirname at dronegen time * Removed "workflow-tag" argument from OPRT GHA call (#24637) * Flipped environment logic for OS package promotion (#24639) * Fixed OPRT migration issues (#24655) * Fixed OPRT migration issues * Removed package-to-test from unsupported teleport-ent-updater package * Added flag to `gh-trigger-workflow` tool to wait for pre-existing runs (#24696) * Added flag to `gh-trigger-workflow tool` to wait for pre-existing runs * Addressed PR comments * workflowId -> workflowID * Id -> ID * Updated promotion pipelines to publish OS packages in series (#24753) * Removed pipeline * Removed teleport-ent-updater deployment --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
fheinecke
added a commit
that referenced
this pull request
Apr 19, 2023
* Increase GHA build timeout (#22926) Our ARM64 build fails quite frequently due to 30 minutes timeout. This PR increases the build timeout to one hour. * Migrate publishing of new APT and YUM repos to GHA (#24350) * Deleted OPRT from this repo * Migrated dronegen to call gha workflow * Removed dead pipelines * Removed unused function to appease linter * Accounted for private repo promotions * Updated to use package name filter * Accounted for teleport-ent-updater publishing * Added missing `mkdir` call when determining if a release is a pre-release. (#24634) * Added missing mkdir call * Updated to calculate dirname at dronegen time * Removed "workflow-tag" argument from OPRT GHA call (#24637) * Flipped environment logic for OS package promotion (#24639) * Fixed OPRT migration issues (#24655) * Fixed OPRT migration issues * Removed package-to-test from unsupported teleport-ent-updater package * Added flag to `gh-trigger-workflow` tool to wait for pre-existing runs (#24696) * Added flag to `gh-trigger-workflow tool` to wait for pre-existing runs * Addressed PR comments * workflowId -> workflowID * Id -> ID * Updated promotion pipelines to publish OS packages in series (#24753) * Removed pipeline * Removed teleport-ent-updater deployment --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
fheinecke
added a commit
that referenced
this pull request
Apr 20, 2023
* Increase GHA build timeout (#22926) Our ARM64 build fails quite frequently due to 30 minutes timeout. This PR increases the build timeout to one hour. * Migrate publishing of new APT and YUM repos to GHA (#24350) * Deleted OPRT from this repo * Migrated dronegen to call gha workflow * Removed dead pipelines * Removed unused function to appease linter * Accounted for private repo promotions * Updated to use package name filter * Accounted for teleport-ent-updater publishing * Added missing `mkdir` call when determining if a release is a pre-release. (#24634) * Added missing mkdir call * Updated to calculate dirname at dronegen time * Removed "workflow-tag" argument from OPRT GHA call (#24637) * Flipped environment logic for OS package promotion (#24639) * Fixed OPRT migration issues (#24655) * Fixed OPRT migration issues * Removed package-to-test from unsupported teleport-ent-updater package * Added flag to `gh-trigger-workflow` tool to wait for pre-existing runs (#24696) * Added flag to `gh-trigger-workflow tool` to wait for pre-existing runs * Addressed PR comments * workflowId -> workflowID * Id -> ID * Updated promotion pipelines to publish OS packages in series (#24753) * Removed pipeline * Removed teleport-ent-updater deployment --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
fheinecke
added a commit
that referenced
this pull request
Apr 20, 2023
* OS packaging and auto updates backport - v12 (#24781) * Increase GHA build timeout (#22926) Our ARM64 build fails quite frequently due to 30 minutes timeout. This PR increases the build timeout to one hour. * Migrate publishing of new APT and YUM repos to GHA (#24350) * Deleted OPRT from this repo * Migrated dronegen to call gha workflow * Removed dead pipelines * Removed unused function to appease linter * Accounted for private repo promotions * Updated to use package name filter * Accounted for teleport-ent-updater publishing * Added missing `mkdir` call when determining if a release is a pre-release. (#24634) * Added missing mkdir call * Updated to calculate dirname at dronegen time * Removed "workflow-tag" argument from OPRT GHA call (#24637) * Flipped environment logic for OS package promotion (#24639) * Fixed OPRT migration issues (#24655) * Fixed OPRT migration issues * Removed package-to-test from unsupported teleport-ent-updater package * Added flag to `gh-trigger-workflow` tool to wait for pre-existing runs (#24696) * Added flag to `gh-trigger-workflow tool` to wait for pre-existing runs * Addressed PR comments * workflowId -> workflowID * Id -> ID * Updated promotion pipelines to publish OS packages in series (#24753) * Removed pipeline * Removed teleport-ent-updater deployment --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com> * Removed accidental backport of *-teleport-oci-distroless-images --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
r0mant
pushed a commit
that referenced
this pull request
Apr 20, 2023
* OS packaging and auto updates backport - v12 (#24781) * Increase GHA build timeout (#22926) Our ARM64 build fails quite frequently due to 30 minutes timeout. This PR increases the build timeout to one hour. * Migrate publishing of new APT and YUM repos to GHA (#24350) * Deleted OPRT from this repo * Migrated dronegen to call gha workflow * Removed dead pipelines * Removed unused function to appease linter * Accounted for private repo promotions * Updated to use package name filter * Accounted for teleport-ent-updater publishing * Added missing `mkdir` call when determining if a release is a pre-release. (#24634) * Added missing mkdir call * Updated to calculate dirname at dronegen time * Removed "workflow-tag" argument from OPRT GHA call (#24637) * Flipped environment logic for OS package promotion (#24639) * Fixed OPRT migration issues (#24655) * Fixed OPRT migration issues * Removed package-to-test from unsupported teleport-ent-updater package * Added flag to `gh-trigger-workflow` tool to wait for pre-existing runs (#24696) * Added flag to `gh-trigger-workflow tool` to wait for pre-existing runs * Addressed PR comments * workflowId -> workflowID * Id -> ID * Updated promotion pipelines to publish OS packages in series (#24753) * Removed pipeline * Removed teleport-ent-updater deployment --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com> * Resigned drone.yml --------- Co-authored-by: Jakub Nyckowski <jakub.nyckowski@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where promotion fails due to a missing directory when determining if the promotion is for a pre-release.