Conversation
atburke
force-pushed
the
atburke/gcp-join-method
branch
from
fd6364a to
ce571e5
Compare
strideynet
reviewed
May 4, 2023
Contributor
There was a problem hiding this comment.
GCP join method needs adding to list at https://github.com/gravitational/teleport/pull/24493/files#diff-125925312bcdffb42ccda3ee44fe8eb2ee10fce23dbdad650a9e00be7521c170R200
strideynet
approved these changes
May 8, 2023
hugoShaka
requested changes
May 9, 2023
Contributor
hugoShaka
left a comment
hugoShaka
left a comment
There was a problem hiding this comment.
Could you add a couple of items in .github/ISSUE_TEMPLATE/testplan.md for this feature?
hugoShaka
approved these changes
May 9, 2023
This change implements the GCP join method.
atburke
force-pushed
the
atburke/gcp-join-method
branch
from
cd1f16d to
7d6177d
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
atburke
added a commit
that referenced
this pull request
May 12, 2023
This change implements the GCP join method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the GCP join method (RFD). Part of #22815.