Conversation
zmb3
reviewed
Apr 17, 2023
atburke
force-pushed
the
atburke/gcp-validate-token
branch
from
93b9ae0 to
04dfab7
Compare
strideynet
reviewed
Apr 26, 2023
strideynet
reviewed
May 2, 2023
atburke
force-pushed
the
atburke/gcp-validate-token
branch
from
f71d851 to
333c60f
Compare
strideynet
approved these changes
May 3, 2023
mdwn
approved these changes
May 3, 2023
Contributor
mdwn
left a comment
mdwn
left a comment
There was a problem hiding this comment.
Just a few nits, but LGTM. Approving!
atburke
force-pushed
the
atburke/gcp-validate-token
branch
from
333c60f to
ed73bc3
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
atburke
added a commit
that referenced
this pull request
May 12, 2023
This change adds validation for ID tokens generated for GCP VMs. (#24492)
atburke
added a commit
that referenced
this pull request
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds validation for ID tokens generated for GCP VMs. Part of #22815.
Should merge after #23946 and before #24493.