Add the new access verb use to web user context#24463
Merged
Conversation
ravicious
reviewed
Apr 13, 2023
Member
There was a problem hiding this comment.
Is there any way we could add use only to the relevant resource? #24133 adds this verb in the first place but even then, it seems to add it only for integrations and not every resource.
teleport/lib/services/presets.go
Line 88 in 60a59f4
I feel like down the line it might be confusing as to why every resource has the use verb defined even though it's not used for that particular resource. I'm basing this on seeing the changes that were made in user.test.ts.
Contributor
Author
There was a problem hiding this comment.
i think that's a good suggestion: 4b3cf20
kimlisa
force-pushed
the
lisa/add-use-verb-user-context
branch
3 times, most recently
from
68ba6f5 to
4b3cf20
Compare
ravicious
approved these changes
Apr 14, 2023
kimlisa
force-pushed
the
lisa/add-use-verb-user-context
branch
from
4b3cf20 to
03ebeb9
Compare
public-teleport-github-review-bot
Bot
removed the request for review
from rudream
kimlisa
added a commit
that referenced
this pull request
May 2, 2023
* BE: Add field for verb use for user ACL * FE: Add the new use access verb * Only define use verb for relevant resources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #22129
merged PR #24133, adds a new access verb
use