Skip to content

Integration: add service to server and client#24133

Merged
marcoandredinis merged 3 commits intomasterfrom
marco/integration_resource_client_server
Apr 12, 2023
Merged

Integration: add service to server and client#24133
marcoandredinis merged 3 commits intomasterfrom
marco/integration_resource_client_server

Conversation

@marcoandredinis
Copy link
Copy Markdown
Contributor

This PR is mostly glue and initialization:

  • adds the Integrations service to the server
  • adds wrappers to the client
  • adds cache (only for auth)

RFD: https://github.com/gravitational/teleport/blob/master/rfd/0119-aws-api-integration-using-oidc.md

@github-actions github-actions Bot requested review from rosstimothy and tigrato April 5, 2023 17:33
@marcoandredinis marcoandredinis force-pushed the marco/integration_resource_client_server branch from a4cc7e0 to c93c71c Compare April 5, 2023 17:34
Comment thread lib/services/presets.go Outdated
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm adding the VerbUse now to leverage the defaultAllowRules.

If we don't add it now, but only add it later, it won't do the migration.
Migrations only happens when the resource is not configured at all

@marcoandredinis marcoandredinis force-pushed the marco/integration_resource_client_server branch from c93c71c to eea92ca Compare April 5, 2023 18:36
Comment thread lib/cache/cache.go Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will any other instance need to cache integrations? If so they should be added before v13 is cut.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right 👍
I should add it to Proxy as well
But the backport to v12 will not add it

I'll update it

@marcoandredinis marcoandredinis force-pushed the marco/integration_resource_client_server branch from eea92ca to 2e9c8d0 Compare April 6, 2023 15:35
@marcoandredinis marcoandredinis force-pushed the marco/integration_resource_client_server branch from 2e9c8d0 to 2436872 Compare April 6, 2023 19:04
@marcoandredinis marcoandredinis force-pushed the marco/integration_resource_client_server branch 9 times, most recently from 693ca82 to f3e4523 Compare April 12, 2023 09:12
@marcoandredinis marcoandredinis added discover Issues related to Teleport Discover backport/branch/v12 labels Apr 12, 2023
@marcoandredinis marcoandredinis force-pushed the marco/integration_resource_client_server branch from f3e4523 to 60a59f4 Compare April 12, 2023 11:20
@marcoandredinis marcoandredinis added this pull request to the merge queue Apr 12, 2023
Merged via the queue into master with commit c0e5e1a Apr 12, 2023
@marcoandredinis marcoandredinis deleted the marco/integration_resource_client_server branch April 12, 2023 11:51
@public-teleport-github-review-bot
Copy link
Copy Markdown

@marcoandredinis See the table below for backport results.

Branch Result
branch/v12 Failed

marcoandredinis added a commit that referenced this pull request Apr 12, 2023
* Integration: add service to server and client

* Add cache for Integration to Proxy

* Add RO for Integration resource for Proxy role
marcoandredinis added a commit that referenced this pull request Apr 12, 2023
* Integration: add service to server and client (#24133)

* Integration: add service to server and client

* Add cache for Integration to Proxy

* Add RO for Integration resource for Proxy role

* Remove Integration resource caching for Proxy

* fix bad merge from merge conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discover Issues related to Teleport Discover size/md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants