Integration: add service to server and client#24133
Merged
marcoandredinis merged 3 commits intomasterfrom Apr 12, 2023
Merged
Conversation
a4cc7e0 to
c93c71c
Compare
marcoandredinis
commented
Apr 5, 2023
Contributor
Author
There was a problem hiding this comment.
I'm adding the VerbUse now to leverage the defaultAllowRules.
If we don't add it now, but only add it later, it won't do the migration.
Migrations only happens when the resource is not configured at all
c93c71c to
eea92ca
Compare
rosstimothy
approved these changes
Apr 6, 2023
Contributor
There was a problem hiding this comment.
Will any other instance need to cache integrations? If so they should be added before v13 is cut.
Contributor
Author
There was a problem hiding this comment.
Oh right 👍
I should add it to Proxy as well
But the backport to v12 will not add it
I'll update it
eea92ca to
2e9c8d0
Compare
r0mant
approved these changes
Apr 6, 2023
2e9c8d0 to
2436872
Compare
693ca82 to
f3e4523
Compare
f3e4523 to
60a59f4
Compare
|
@marcoandredinis See the table below for backport results.
|
marcoandredinis
added a commit
that referenced
this pull request
Apr 12, 2023
* Integration: add service to server and client * Add cache for Integration to Proxy * Add RO for Integration resource for Proxy role
marcoandredinis
added a commit
that referenced
this pull request
Apr 12, 2023
* Integration: add service to server and client (#24133) * Integration: add service to server and client * Add cache for Integration to Proxy * Add RO for Integration resource for Proxy role * Remove Integration resource caching for Proxy * fix bad merge from merge conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mostly glue and initialization:
RFD: https://github.com/gravitational/teleport/blob/master/rfd/0119-aws-api-integration-using-oidc.md