WebDiscover: Add open source integrations enrollment page#24399
Merged
WebDiscover: Add open source integrations enrollment page#24399
Conversation
ryanclark
approved these changes
Apr 11, 2023
Copied over tile styling and header description with minor refactoring from enterprise
This feature is manually disabled. The user ACL for this screen is manually set to always return false.
kimlisa
force-pushed
the
lisa/add-integration-enrollment
branch
from
3a0d155 to
0aa48d5
Compare
avatus
approved these changes
Apr 11, 2023
Contributor
avatus
left a comment
avatus
left a comment
There was a problem hiding this comment.
Thanks for all the tests!!
public-teleport-github-review-bot
Bot
removed the request for review
from rudream
justinas
pushed a commit
that referenced
this pull request
Apr 14, 2023
* Create a shareable tooltip no permission badge comp * Implement the open source enroll integration screen Copied over tile styling and header description with minor refactoring from enterprise * Add integration feature This feature is manually disabled. The user ACL for this screen is manually set to always return false. * Remove testing implementation detail? * Make open source check for only integration resource access * Update snapshot
justinas
added a commit
that referenced
this pull request
Apr 14, 2023
* Hosted plugins: add plugin management UI prerequisites (#22831) * Add GetType() to Plugin * Add Plugins feature flag to web * Run prettier * Update e_imports.go with slack plugin subpackage Respective enterprise changes imports a new subpackage, which pulls new dependencies. * Hosted plugins onboarding prerequisites (#23234) * Respect route exactness in TopNav * Allow submitting CSRF token via form * Skip "safe" methods in CSRF checks * Export getXCSRFToken * Add WithAuth2 * Passthrough "name" of FieldInput Allows it to be used in an actual form * icomoon: add hashtag icon * Add GetAvailablePluginTypes to PluginService proto * Expose ProxyPublicAddr For use in Enterprise web Plugin * Run prettier * Factor out app.MetaRedirect * Rename: WithAuth2 -> WithAuthCookieAndCSRF * Run GCI * Renegerate protos * WebDiscover: Add OS integrations page (#24108) * Move icons to design pkg to share between packages * Moved integration routes from enterprise * Add integrations ACL to user context Also fixes inaccurate plugin perm checking for features. Plugin "create" is moved to new feature flag "enrollIntegrations". * Moved feature definition from enterprise * Add integration service and types Also moved Plugin type from enterprise * Create add integration button comp for use in both OS/enterprise * Move integration list from enteprise (refactored) * Create open source integrations comp * Update user.test * Address CRs * Make updates in response to backend PR updates * Add clarifying comment * Remove return value, export integration list * WebDiscover: Add open source integrations enrollment page (#24399) * Create a shareable tooltip no permission badge comp * Implement the open source enroll integration screen Copied over tile styling and header description with minor refactoring from enterprise * Add integration feature This feature is manually disabled. The user ACL for this screen is manually set to always return false. * Remove testing implementation detail? * Make open source check for only integration resource access * Update snapshot * Plugin UX improvement prerequisites (#24436) * Add new assets for integration enroll flow * Adapt integration status after switch to enum * Prettier * Fix some lints * Rename enum numbers according to conventions --------- Co-authored-by: Lisa Kim <lisa@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #22129
enterprise part: https://github.com/gravitational/teleport.e/pull/1113
integration)lacks permissionred colored badge, when on hover display tooltip messageScreenshot
doesn't do anything upon click, but this feature is also manually disabled (menu tab will not render unless you change the code)