WebDiscover: Add OS integrations page#24108
Merged
Conversation
Also fixes inaccurate plugin perm checking for features. Plugin "create" is moved to new feature flag "enrollIntegrations".
Also moved Plugin type from enterprise
ryanclark
reviewed
Apr 5, 2023
kimlisa
requested review from
ryanclark
and removed request for
gzdunek and
ravicious
ibeckermayer
reviewed
Apr 6, 2023
Contributor
ibeckermayer
left a comment
ibeckermayer
left a comment
There was a problem hiding this comment.
Code LGTM.
This integration feature is off until some backend work has been done
I understand that some things are a WIP here, but is this shippable code? As in, are there components that are essentially broken until the backend work gets done?
Contributor
Author
kind of, the api path to get integrations is not implemented in the back yet (draft PR is up though) so you'll get 404 if you try to hit this path.
yes, i think the current state is ok, this feature is disabled in the front, and the rbac rule for |
Contributor
Author
|
@ibeckermayer @ryanclark here is the backend PR that is being reviewed atm: #24145, b/c this PR is now active, as a result i had to make some changes which is addressed here: a8d2d30 |
ryanclark
approved these changes
Apr 11, 2023
| case 'Bot not invited to channel': | ||
| return Status.Warning; | ||
| } | ||
| return; |
ibeckermayer
approved these changes
Apr 11, 2023
justinas
pushed a commit
that referenced
this pull request
Apr 14, 2023
* Move icons to design pkg to share between packages * Moved integration routes from enterprise * Add integrations ACL to user context Also fixes inaccurate plugin perm checking for features. Plugin "create" is moved to new feature flag "enrollIntegrations". * Moved feature definition from enterprise * Add integration service and types Also moved Plugin type from enterprise * Create add integration button comp for use in both OS/enterprise * Move integration list from enteprise (refactored) * Create open source integrations comp * Update user.test * Address CRs * Make updates in response to backend PR updates * Add clarifying comment * Remove return value, export integration list
justinas
added a commit
that referenced
this pull request
Apr 14, 2023
* Hosted plugins: add plugin management UI prerequisites (#22831) * Add GetType() to Plugin * Add Plugins feature flag to web * Run prettier * Update e_imports.go with slack plugin subpackage Respective enterprise changes imports a new subpackage, which pulls new dependencies. * Hosted plugins onboarding prerequisites (#23234) * Respect route exactness in TopNav * Allow submitting CSRF token via form * Skip "safe" methods in CSRF checks * Export getXCSRFToken * Add WithAuth2 * Passthrough "name" of FieldInput Allows it to be used in an actual form * icomoon: add hashtag icon * Add GetAvailablePluginTypes to PluginService proto * Expose ProxyPublicAddr For use in Enterprise web Plugin * Run prettier * Factor out app.MetaRedirect * Rename: WithAuth2 -> WithAuthCookieAndCSRF * Run GCI * Renegerate protos * WebDiscover: Add OS integrations page (#24108) * Move icons to design pkg to share between packages * Moved integration routes from enterprise * Add integrations ACL to user context Also fixes inaccurate plugin perm checking for features. Plugin "create" is moved to new feature flag "enrollIntegrations". * Moved feature definition from enterprise * Add integration service and types Also moved Plugin type from enterprise * Create add integration button comp for use in both OS/enterprise * Move integration list from enteprise (refactored) * Create open source integrations comp * Update user.test * Address CRs * Make updates in response to backend PR updates * Add clarifying comment * Remove return value, export integration list * WebDiscover: Add open source integrations enrollment page (#24399) * Create a shareable tooltip no permission badge comp * Implement the open source enroll integration screen Copied over tile styling and header description with minor refactoring from enterprise * Add integration feature This feature is manually disabled. The user ACL for this screen is manually set to always return false. * Remove testing implementation detail? * Make open source check for only integration resource access * Update snapshot * Plugin UX improvement prerequisites (#24436) * Add new assets for integration enroll flow * Adapt integration status after switch to enum * Prettier * Fix some lints * Rename enum numbers according to conventions --------- Co-authored-by: Lisa Kim <lisa@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recommend reviewing by commit.
Enterprise PR (has the screenshots): https://github.com/gravitational/teleport.e/pull/1081
Moved some integration logic from enterprise to here since the
integrationresource is supported for both enterprise and OS.This integration feature is off until some backend work has been done
part of #22129