Skip to content

Docs: add flag var and extra detail for debug#24242

Merged
alexfornuto merged 2 commits intopschisa-patch-4from
afornuto/patch-4/patch1
Apr 7, 2023
Merged

Docs: add flag var and extra detail for debug#24242
alexfornuto merged 2 commits intopschisa-patch-4from
afornuto/patch-4/patch1

Conversation

@alexfornuto
Copy link
Copy Markdown
Contributor

@alexfornuto alexfornuto commented Apr 6, 2023

This is an attempt to solve the issue @rosstimothy brought up with #24200.

@github-actions github-actions Bot requested review from ptgott, r0mant, xinding33 and zmb3 April 6, 2023 20:19
@alexfornuto alexfornuto changed the title add flag var and extra detail for debug Docs: add flag var and extra detail for debug Apr 6, 2023
@alexfornuto alexfornuto requested review from pschisa and rosstimothy and removed request for r0mant, xinding33 and zmb3 April 6, 2023 20:24
Comment thread docs/pages/includes/diagnostics/diag-addr-prereqs-tabs.mdx Outdated
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
@alexfornuto alexfornuto merged commit 2839969 into pschisa-patch-4 Apr 7, 2023
@alexfornuto alexfornuto deleted the afornuto/patch-4/patch1 branch April 7, 2023 15:47
pschisa added a commit that referenced this pull request Apr 7, 2023
* Fixes to metrics docs

Based on my testing, setting Teleport in debug mode is not required to expose the metrics

~~~
# cat /etc/systemd/system/teleport.service
ExecStart=/usr/local/bin/teleport start  --config=/etc/teleport.yaml --diag-addr=http://172.31.36.239:3434 --pid-file=/run/teleport/teleport.pid

# cat /etc/teleport.yaml
teleport:
  log:
    severity: INFO

# curl http://172.31.36.239:3434/metrics | more
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0# HELP audit_failed_disk_monitoring Number of times disk monitoring failed.
# TYPE audit_failed_disk_monitoring counter
audit_failed_disk_monitoring 0
# HELP audit_failed_emit_events Number of times emitting audit event failed.
# TYPE audit_failed_emit_events counter
audit_failed_emit_events 0
# HELP audit_percentage_disk_space_used Percentage disk space used.
# TYPE audit_percentage_disk_space_used gauge
audit_percentage_disk_space_used 100
# HELP audit_server_open_files Number of open audit files
# TYPE audit_server_open_files gauge
audit_server_open_files 0
...
~~~

Also, curling the diag endpoint without the metrics part returns a 404 page not found which is a confusing way to validate it is working

~~~
# curl http://172.31.36.239:3434/
404 page not found
~~~

* Docs: add flag var and extra detail for debug (#24242)

* add flag var and extra detail for debug

* Update docs/pages/includes/diagnostics/diag-addr-prereqs-tabs.mdx

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

---------

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

* Update diag-addr-prereqs-tabs.mdx

---------

Co-authored-by: Alex Fornuto <alex.fornuto@goteleport.com>
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
github-actions Bot pushed a commit that referenced this pull request Apr 7, 2023
* add flag var and extra detail for debug

* Update docs/pages/includes/diagnostics/diag-addr-prereqs-tabs.mdx

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

---------

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
pschisa added a commit that referenced this pull request Apr 7, 2023
* Fixes to metrics docs

Based on my testing, setting Teleport in debug mode is not required to expose the metrics

~~~
# cat /etc/systemd/system/teleport.service
ExecStart=/usr/local/bin/teleport start  --config=/etc/teleport.yaml --diag-addr=http://172.31.36.239:3434 --pid-file=/run/teleport/teleport.pid

# cat /etc/teleport.yaml
teleport:
  log:
    severity: INFO

# curl http://172.31.36.239:3434/metrics | more
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0# HELP audit_failed_disk_monitoring Number of times disk monitoring failed.
# TYPE audit_failed_disk_monitoring counter
audit_failed_disk_monitoring 0
# HELP audit_failed_emit_events Number of times emitting audit event failed.
# TYPE audit_failed_emit_events counter
audit_failed_emit_events 0
# HELP audit_percentage_disk_space_used Percentage disk space used.
# TYPE audit_percentage_disk_space_used gauge
audit_percentage_disk_space_used 100
# HELP audit_server_open_files Number of open audit files
# TYPE audit_server_open_files gauge
audit_server_open_files 0
...
~~~

Also, curling the diag endpoint without the metrics part returns a 404 page not found which is a confusing way to validate it is working

~~~
# curl http://172.31.36.239:3434/
404 page not found
~~~

* Docs: add flag var and extra detail for debug (#24242)

* add flag var and extra detail for debug

* Update docs/pages/includes/diagnostics/diag-addr-prereqs-tabs.mdx

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

---------

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

* Update diag-addr-prereqs-tabs.mdx

---------

Co-authored-by: Alex Fornuto <alex.fornuto@goteleport.com>
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants