Conversation
Based on my testing, setting Teleport in debug mode is not required to expose the metrics ~~~ # cat /etc/systemd/system/teleport.service ExecStart=/usr/local/bin/teleport start --config=/etc/teleport.yaml --diag-addr=http://172.31.36.239:3434 --pid-file=/run/teleport/teleport.pid # cat /etc/teleport.yaml teleport: log: severity: INFO # curl http://172.31.36.239:3434/metrics | more % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0# HELP audit_failed_disk_monitoring Number of times disk monitoring failed. # TYPE audit_failed_disk_monitoring counter audit_failed_disk_monitoring 0 # HELP audit_failed_emit_events Number of times emitting audit event failed. # TYPE audit_failed_emit_events counter audit_failed_emit_events 0 # HELP audit_percentage_disk_space_used Percentage disk space used. # TYPE audit_percentage_disk_space_used gauge audit_percentage_disk_space_used 100 # HELP audit_server_open_files Number of open audit files # TYPE audit_server_open_files gauge audit_server_open_files 0 ... ~~~ Also, curling the diag endpoint without the metrics part returns a 404 page not found which is a confusing way to validate it is working ~~~ # curl http://172.31.36.239:3434/ 404 page not found ~~~
github-actions
Bot
requested review from
alexfornuto,
ptgott,
r0mant,
xinding33 and
zmb3
rosstimothy
requested changes
Apr 6, 2023
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
This is included in several diagnostics pages, some of which do actually require --debug in order to work(most notably collecting pprof profiles).
zmb3
approved these changes
Apr 6, 2023
Contributor
Author
|
hmmm so this might not be a simple change after all. I'll check how the doc's team wants to proceed @ptgott @alexfornuto |
Contributor
|
It looks to me like |
* add flag var and extra detail for debug * Update docs/pages/includes/diagnostics/diag-addr-prereqs-tabs.mdx Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> --------- Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
alexfornuto
approved these changes
Apr 7, 2023
public-teleport-github-review-bot
Bot
removed request for
ptgott,
r0mant and
xinding33
rosstimothy
reviewed
Apr 7, 2023
Contributor
Author
|
v10 and v11 did not get the debug added so not backport required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on my testing, setting Teleport in debug mode is not required to expose the metrics
Also, curling the diag endpoint without the metrics part returns a 404 page not found which is a confusing way to validate it is working