[v12] Vendor slack plugin and supporting libraries#23475
Merged
hugoShaka merged 5 commits intobranch/v12from Mar 24, 2023
Merged
[v12] Vendor slack plugin and supporting libraries#23475hugoShaka merged 5 commits intobranch/v12from
hugoShaka merged 5 commits intobranch/v12from
Conversation
justinas
force-pushed
the
justinas/v12/backport-23045
branch
2 times, most recently
from
8986d80 to
8caa033
Compare
justinas
changed the title
justinas
changed the title
justinas
requested review from
klizhentas,
r0mant,
russjones and
zmb3
as code owners
|
@justinas - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
1 similar comment
|
@justinas - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
hugoShaka
approved these changes
Mar 24, 2023
r0mant
approved these changes
Mar 24, 2023
hugoShaka
force-pushed
the
justinas/v12/backport-23045
branch
2 times, most recently
from
fbf38cc to
4d9d176
Compare
When gravitational/teleport-plugins imports this in CI, gravitational/teleport/... is not writable
hugoShaka
force-pushed
the
justinas/v12/backport-23045
branch
from
4d9d176 to
a38d27b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #23045, and adds some supporting changes. Effectively backports parts of #22983.
Please review everything past the two first commits (which are a straightforward backport).