kube-updater: add Dockerfile & GHA pipelines#22983
Conversation
hugoShaka
requested review from
klizhentas,
r0mant,
russjones and
zmb3
as code owners
hugoShaka
force-pushed
the
hugo/kube-updater-pipeline
branch
from
7e35ba9 to
7c9a707
Compare
|
|
||
| .PHONY: docker-build | ||
| docker-build: ## Build docker image | ||
| docker buildx build --platform="$(OS)/$(ARCH)" --build-arg BUILDBOX=$(PLATFORM_BUILDBOX) \ |
There was a problem hiding this comment.
Should we sign our upgrader image as well during publishing? cc @tcsc
| scheme = runtime.NewScheme() | ||
| ) | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
What happened to all this stuff? Was this a leftover?
There was a problem hiding this comment.
Yes, those functions were helpers for the first end-to-end testing approach. However, I had to change the testing technique mid-course because we rely on pod status for some maintenance triggers and controllers. However, envtest runs a real Kubernetes API server which starts to fight for pod status reconciliation.
r0mant
requested review from
tcsc
and removed request for
probakowski and
rudream
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
@hugoShaka I'm going to remove operator tests from the required checks so you can merge this and then we'll mark the integrations check as required instead.
hugoShaka
force-pushed
the
hugo/kube-updater-pipeline
branch
from
836a39c to
b2d9ff7
Compare
hugoShaka
force-pushed
the
hugo/kube-updater-pipeline
branch
from
b2d9ff7 to
f0a95a2
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
3 participants
This PR is part of #22732
It does the following kube-agent-updater changes:
integrations/operatoronelint-kube-agent-updatertarget on the root Makefile for CI purposes