Add per-session mfa support to connection testers#22528
Merged
Conversation
kimlisa
force-pushed
the
lisa/mfa-check-conntest
branch
2 times, most recently
from
486ecd4 to
ba7c8b3
Compare
codingllama
reviewed
Mar 2, 2023
Contributor
|
Thanks for the cleanly-split backend PR. |
marcoandredinis
approved these changes
Mar 3, 2023
Contributor
marcoandredinis
left a comment
marcoandredinis
left a comment
There was a problem hiding this comment.
LGTM after Alan's comments
I've just tested (from the UI Branch) and looks to be working 👍
| "github.com/gravitational/teleport/lib/session" | ||
| "github.com/gravitational/teleport/lib/tlsca" | ||
|
|
||
| "github.com/pquerna/otp/totp" |
Contributor
There was a problem hiding this comment.
You'll probably need to move this import to the 2nd group (or run make fix-imports)
kimlisa
force-pushed
the
lisa/mfa-check-conntest
branch
from
dcd17b5 to
037ea12
Compare
codingllama
approved these changes
Mar 7, 2023
Contributor
There was a problem hiding this comment.
FYI, I tend to use wantErr string in tests like this, so the name was alright IMO. (No need to change it though.)
kimlisa
force-pushed
the
lisa/mfa-check-conntest
branch
from
cff9f2a to
d01349f
Compare
kimlisa
force-pushed
the
lisa/mfa-check-conntest
branch
from
d01349f to
f035473
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
kimlisa
added a commit
that referenced
this pull request
Mar 10, 2023
* Add MFAAuthenticateResponse field to GenerateUserCerts * Pass MFA response for connection testers * Add checking MFA web endpoint * Address CRs
kimlisa
added a commit
that referenced
this pull request
Mar 10, 2023
* Add MFAAuthenticateResponse field to GenerateUserCerts * Pass MFA response for connection testers * Add checking MFA web endpoint * Address CRs
kimlisa
added a commit
that referenced
this pull request
Mar 10, 2023
* Add MFAAuthenticateResponse field to GenerateUserCerts * Pass MFA response for connection testers * Add checking MFA web endpoint * Address CRs
kimlisa
added a commit
that referenced
this pull request
Mar 10, 2023
) * Add per-session mfa support to connection testers (#22528) * Add MFAAuthenticateResponse field to GenerateUserCerts * Pass MFA response for connection testers * Add checking MFA web endpoint * Address CRs * Fix lint: all cap acronym
kimlisa
added a commit
that referenced
this pull request
Mar 10, 2023
* Add per-session mfa support to connection testers (#22528) * Add MFAAuthenticateResponse field to GenerateUserCerts * Pass MFA response for connection testers * Add checking MFA web endpoint * Address CRs * Fix lint: all cap acronym
kimlisa
added a commit
that referenced
this pull request
Mar 10, 2023
) * Add per-session mfa support to connection testers (#22528) * Add MFAAuthenticateResponse field to GenerateUserCerts * Pass MFA response for connection testers * Add checking MFA web endpoint * Address CRs * Use legacy field (new fields doesn't exist) * Fix lint: all cap acronym
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #16702
Description
Implements the backend part of RFD 0111