RFD 01111 - Support connection testers when per-session MFA is enabled#22458
Merged
RFD 01111 - Support connection testers when per-session MFA is enabled#22458
Conversation
kimlisa
requested review from
codingllama and
marcoandredinis
and removed request for
jakule and
tobiaszheller
zmb3
reviewed
Mar 1, 2023
| state: draft | ||
| --- | ||
|
|
||
| # RFD 0111 - GenerateUserCerts accepts and validates a MFA authentication response |
Collaborator
There was a problem hiding this comment.
This title seems more like an implementation detail than a description of the proposed change.
How about something like:
Suggested change
| # RFD 0111 - GenerateUserCerts accepts and validates a MFA authentication response | |
| # RFD 0111 - Support connection testers when per-session MFA is enabled |
Collaborator
There was a problem hiding this comment.
Same goes for the PR title :-)
kimlisa
changed the title
codingllama
approved these changes
Mar 1, 2023
Contributor
codingllama
left a comment
codingllama
left a comment
There was a problem hiding this comment.
Thanks for the RFD, Lisa. Short and sweet.
This was referenced Mar 2, 2023
marcoandredinis
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rendered: https://github.com/gravitational/teleport/blob/5af70fdb6d9a81d2da6ba0676e4ce280a0bb6b18/rfd/0111-support-connection-testers-with-per-session-mfa.md