[Web] Fix missing --request-id= flag in UI for Kubernetes login instructions#21444
Merged
[Web] Fix missing --request-id= flag in UI for Kubernetes login instructions#21444
Conversation
kimlisa
approved these changes
Feb 8, 2023
Contributor
kimlisa
left a comment
kimlisa
left a comment
There was a problem hiding this comment.
thanks for the fix, lgtm after adding a snapshot
Contributor
|
normally you'd wanna start the backport after the master gets approved and merged... |
ryanclark
approved these changes
Feb 8, 2023
Contributor
Author
@kimlisa Yeah this is because I had accidentally made the fix in |
avatus
pushed a commit
that referenced
this pull request
Mar 3, 2023
…uctions (#21444) * fix missing request-id flag for kube login instructions * add snapshot tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Related issue: #14432 (comment)
Fixes a minor regression that was accidentally introduced in gravitational/webapps#1298 which caused the
--request-id=flag to no longer appear in the generated login command for Kubes in the UI (while having a role from an Access Request assumed).