[v10] Enable BuildKit for buildbox#21399
Merged
Merged
Conversation
gzdunek
approved these changes
Feb 7, 2023
hatched
approved these changes
Feb 7, 2023
espadolini
approved these changes
Feb 7, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from zmb3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#21306 introduced Dockerfile changes to v10 which require BuildKit. push pipelines run by drone & "Build Ubuntu Buildbox" GitHub action have failed because they attempted to execute Dockerfile statements which were supposed to be executed only on arm64. Those statements wouldn't be executed with BuildKit enabled.
BuildKit was enabled for buildboxes in #14036. That PR however was not backported to v10 so only v11+ has buildkit enabled.
As far as I can judge from #14036, no other special changes are necessary when enabling BuildKit.
Also, for some reason the drone pipeline which builds buildboxes succeeded, but push pipelines which started rebuilding the image have failed.