[v10] Prepare for Dockerfile-teleterm removal#21306
Merged
ravicious merged 3 commits intobranch/v10from Feb 7, 2023
Merged
Conversation
`make protos-up-to-date` and thus `make grpc` is now run as a part of CI. Thus I cannot just change the buildbox Dockerfile when backporting #20032 as it will use the old buildbox image which won't be able to compile JS protos. I extracted relevant Dockerfile changes from the backport branch. Once this commit lands in v10, I should be able to make CI pass for the backport PR.
zmb3
approved these changes
Feb 6, 2023
gzdunek
approved these changes
Feb 7, 2023
public-teleport-github-review-bot
Bot
removed request for
fspmarshall and
mdwn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #20032 (sort of).
This is the equivalent of #21299 for v10 where I've ran into the same issue.
make protos-up-to-dateand thusmake grpcis now run as a part of CI. Thus I cannot just change the buildbox Dockerfile when backporting #20032 as it will use the old buildbox image which won't be able to compile JS protos.I extracted relevant Dockerfile changes from the backport branch. Once this commit lands in v10, I should be able to make CI pass for the backport PR.