Skip to content

Fix operator build #21362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r0mant merged 1 commit into from
Feb 7, 2023
Merged

Fix operator build #21362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/unit-tests-operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ on:
- '/go.sum'
- 'operator/**'
- 'api/types/**'
- 'gen/**'
- 'lib/tbot/**'
- 'build.assets/Makefile'
- 'build.assets/Dockerfile*'
Expand All @@ -20,6 +21,7 @@ on:
- '/go.sum'
- 'operator/**'
- 'api/types/**'
- 'gen/**'
- 'lib/tbot/**'
Copy link
Copy Markdown
Contributor

@hugoShaka hugoShaka Feb 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly this should also contain lib/**. I think the gen/ dependency was added by a lib/something edition, which was likely a dependency of lib/tbot.

Copy link
Copy Markdown
Collaborator Author

@r0mant r0mant Feb 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was also thinking we should just run operator tests on any .go source code change to be safe. It runs fast anyway. Will fix later (after release).

- 'build.assets/Makefile'
- 'build.assets/Dockerfile*'
Expand Down
3 changes: 2 additions & 1 deletion api/types/accountrecovery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ import (
"github.com/gravitational/trace"
)

// NewRecoveryCodes creates a new RecoveryCodes with the given codes and created time.
// NewRecoveryCodes creates a new RecoveryCodes with the given codes and created
// time.
func NewRecoveryCodes(codes []RecoveryCode, created time.Time, username string) (*RecoveryCodesV1, error) {
rc := &RecoveryCodesV1{
Metadata: Metadata{
Expand Down
1 change: 1 addition & 0 deletions operator/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ RUN go mod download

COPY *.go ./
COPY lib/ lib/
COPY gen/ gen/
COPY operator/apis/ operator/apis/
COPY operator/controllers/ operator/controllers/
COPY operator/sidecar/ operator/sidecar/
Expand Down