Fix operator build#21362
Conversation
|
Running a dev release off of branch/v12 with the same fix it looks like it does fix it: https://drone.platform.teleport.sh/gravitational/teleport/20122/27/39. |
| - 'operator/**' | ||
| - 'api/types/**' | ||
| - 'gen/**' | ||
| - 'lib/tbot/**' |
There was a problem hiding this comment.
Sadly this should also contain lib/**. I think the gen/ dependency was added by a lib/something edition, which was likely a dependency of lib/tbot.
There was a problem hiding this comment.
Yeah, I was also thinking we should just run operator tests on any .go source code change to be safe. It runs fast anyway. Will fix later (after release).
|
I'm going to include this fix in my backports of #20810 to v10 and v11. Though I think v10 might not need it as |
|
I'm not backporting the fix to v10 in the end because teleport-operator builds fine on v10 without it and I don't want my PR to await a review from the admin team. |
* Moved teleterm's proto files from their respective `lib/` dir to `proto/`.
* Updated `go_package` of `lib/teleterm` protobufs to match conventions
used by `api/proto` and `proto`.
* `lib/teleterm/api/protogen/golang/v1` before
* `gen/proto/go/teleport/lib/teleterm/v1/` now
* proto package name has been updated to match the new location.
* JS protobufs for now live in `gen/proto/js` in the root folder.
* Connect no longer needs to copy protobufs to its own directory.
* Instead it uses protobufs from `gen/proto/js` so that any change
done through `make grpc` is automatically picked up by Connect.
* Fix operator build (#21362)
---------
Co-authored-by: Roman Tkachenko <roman@goteleport.com>
5 participants
No description provided.