Skip to content

Moderation Session docs update#18143

Merged
stevenGravy merged 16 commits intomasterfrom
stevenGravy/docs/moderatedsessions
May 11, 2023
Merged

Moderation Session docs update#18143
stevenGravy merged 16 commits intomasterfrom
stevenGravy/docs/moderatedsessions

Conversation

@stevenGravy
Copy link
Copy Markdown
Contributor

Provides:

  • fleshed out roles examples. Previous examples would not work with being created
  • clarify on how to join
  • example of joining a moderated session.

Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx
stevenGravy and others added 2 commits November 4, 2022 13:29
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
Copy link
Copy Markdown
Contributor

@alexfornuto alexfornuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: Disregard, was looking at a single commit.

@alexfornuto
Copy link
Copy Markdown
Contributor

As part of the docs team's effort to sort and prioritize docs updates I've added this to our queue and assigned @stevenGravy, since it looks like there are outstanding review comments to be addressed by the author.

Alternately Steven, let us know if you would like the docs team to pick up from here and address the remaining notes.

@ptgott
Copy link
Copy Markdown
Contributor

ptgott commented Jan 18, 2023

@alexfornuto @stevenGravy Just following up on the status of this one. Let me know if you need another review!

@stevenGravy
Copy link
Copy Markdown
Contributor Author

@alexfornuto @stevenGravy Just following up on the status of this one. Let me know if you need another review!

Please take a look when you can @ptgott .

@alexfornuto
Copy link
Copy Markdown
Contributor

@stevenGravy it looks to me like this still has outstanding review items to be addressed by the author.

@stevenGravy
Copy link
Copy Markdown
Contributor Author

@stevenGravy it looks to me like this still has outstanding review items to be addressed by the author.

@alexfornuto Please take a look. Comments addressed and added in web ui joining that is now available.

@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented Feb 23, 2023

Let's hold off on merging this please, as your screenshot is going to go out of date very soon.

Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented Apr 17, 2023

@rudream I assigned this to you so you can include an up-to-date screenshot after the join menu redesign.

Please consider this when backporting - we may not want to backport a change with a screenshot from a future version.

Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
@rudream
Copy link
Copy Markdown
Contributor

rudream commented May 4, 2023

@zmb3 @stevenGravy I created a PR that updates the screenshot. I̶ ̶k̶e̶p̶t̶ ̶t̶h̶e̶ ̶f̶i̶l̶e̶ ̶n̶a̶m̶e̶ ̶t̶h̶e̶ ̶s̶a̶m̶e̶ ̶s̶o̶ ̶i̶t̶ ̶s̶h̶o̶u̶l̶d̶ ̶w̶o̶r̶k̶ ̶w̶i̶t̶h̶ ̶t̶h̶e̶ ̶c̶h̶a̶n̶g̶e̶s̶ ̶i̶n̶ ̶t̶h̶i̶s̶ ̶P̶R̶.̶ #25659

@stevenGravy
Copy link
Copy Markdown
Contributor Author

@zmb3 @stevenGravy I created a PR that updates the screenshot. I kept the file name the same so it should work with the changes in this PR. #25659
Thanks, good to approve then? @zmb3

@zmb3
Copy link
Copy Markdown
Collaborator

zmb3 commented May 4, 2023

There's no need to add the image here if Yassine's PR will just replace it. Can we merge Yassine's branch here instead?

@rudream
Copy link
Copy Markdown
Contributor

rudream commented May 4, 2023

There's no need to add the image here if Yassine's PR will just replace it. Can we merge Yassine's branch here instead?

@zmb3 @stevenGravy Instead of adding a new screenshot here, can we just reference the same one that is used in the Web UI docs? That is the one I am updating in my PR.

@stevenGravy
Copy link
Copy Markdown
Contributor Author

There's no need to add the image here if Yassine's PR will just replace it. Can we merge Yassine's branch here instead?

@zmb3 @stevenGravy Instead of adding a new screenshot here, can we just reference the same one that is used in the Web UI docs? That is the one I am updating in my PR.

Yes I can do that.

@stevenGravy
Copy link
Copy Markdown
Contributor Author

There's no need to add the image here if Yassine's PR will just replace it. Can we merge Yassine's branch here instead?

@zmb3 @stevenGravy Instead of adding a new screenshot here, can we just reference the same one that is used in the Web UI docs? That is the one I am updating in my PR.

Yes I can do that.

Done!

Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated
Comment thread docs/pages/access-controls/guides/moderated-sessions.mdx Outdated

<Admonition title="Note" type="tip">

Joining as a moderator and observer is available for Servers in the UI Console.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "Servers" should be "servers", since it's not a proper noun
  • What is the UI Console?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This meant Web UI but it's redundant since we're showing the joining of servers. Removed

stevenGravy and others added 3 commits May 11, 2023 12:03
Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
@stevenGravy stevenGravy added this pull request to the merge queue May 11, 2023
Merged via the queue into master with commit 42c95bf May 11, 2023
@stevenGravy stevenGravy deleted the stevenGravy/docs/moderatedsessions branch May 11, 2023 16:36
@public-teleport-github-review-bot
Copy link
Copy Markdown

@stevenGravy See the table below for backport results.

Branch Result
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants