Handle private key policy errors for the web UI#17651
Merged
kimlisa merged 3 commits intojoerger/fix-localagent-signersfrom Oct 28, 2022
Merged
Handle private key policy errors for the web UI#17651kimlisa merged 3 commits intojoerger/fix-localagent-signersfrom
kimlisa merged 3 commits intojoerger/fix-localagent-signersfrom
Conversation
- When user registers or resets, when running into policy errors, we don't send back an error, but instead a 200 (to indicate user has successfully registered/resetted) and a flag to determine if policy was enabled - Send back policy configurations for cluster config, this will allow the web UI login page to just display redirection messages without login attempts - For role configured policy, login attempts will be required and a specific error will be returned so that the UI can then better redirect the user
kimlisa
changed the base branch from
master
to
joerger/fix-localagent-signers
12 tasks
strideynet
approved these changes
Oct 25, 2022
Joerger
approved these changes
Oct 25, 2022
Contributor
Joerger
left a comment
Joerger
left a comment
There was a problem hiding this comment.
Can we backport this to v11?
Contributor
This was referenced Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #16168
Description
Please see gravitational/webapps#1298, for UI and copy review. I've tried to target all edge cases, let me know if you folks come up with more.
policy errors, we don't send back an error, but instead
a 200 (to indicate user has successfully registered/resetted)
and a flag to determine if policy was enabled
this will allow the web UI login page to just display
redirection messages without allowing any login attempts
required and a specific error will be returned so that
the UI can then better redirect the user