Update username in local agent if response comes from proxy. #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klizhentas
approved these changes
Mar 7, 2018
If user has not logged in yet, and runs tsh --proxy=example.com ls Teleport launches ad-hoc login screen, however because tsh did not write profile, username and proxy were lost, so any next execution tsh --proxy=example.com ls Will launch the same login screen and will ask for proxy, what is not user-friendly. This PR fixes it by saving profile after ad-hoc login attempts.
russjones
force-pushed
the
rjones/fix-login
branch
from
5587abd to
b29a538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Backport part of #1642 and #1705 from 2.5.0 to
branch/2.4.Implementation
Proposed Solution
Fixes #1749