Populate tsh profile after ad-hoc login. #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russjones
approved these changes
Feb 19, 2018
|
retest this please |
If user has not logged in yet, and runs tsh --proxy=example.com ls Teleport launches ad-hoc login screen, however because tsh did not write profile, username and proxy were lost, so any next execution tsh --proxy=example.com ls Will launch the same login screen and will ask for proxy, what is not user-friendly. This PR fixes it by saving profile after ad-hoc login attempts.
klizhentas
force-pushed
the
sasha/login
branch
from
c6c07f7 to
5d9113d
Compare
kontsevoy
approved these changes
Feb 20, 2018
russjones
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user has not logged in yet, and runs
tsh --proxy=example.com ls
Teleport launches ad-hoc login screen, however
because tsh did not write profile, username
and proxy were lost, so any next execution
tsh --proxy=example.com ls
Will launch the same login screen and will
ask for proxy, what is not user-friendly.
This PR fixes it by saving profile after
ad-hoc login attempts.