Add enterprise module support to Connect builds#17315
Merged
Conversation
avatus
changed the title
EdwardDowling
approved these changes
Oct 12, 2022
rosstimothy
reviewed
Oct 12, 2022
| -F /dev/null' git submodule update --init --recursive webassets || true | ||
| - cd $WORKSPACE_DIR/go/src/github.com/gravitational/webapps | ||
| - GIT_SSH_COMMAND='ssh -i $WORKSPACE_DIR/.ssh/id_rsa -o UserKnownHostsFile=$WORKSPACE_DIR/.ssh/known_hosts | ||
| -F /dev/null' git submodule update --init --recursive packages/webapps.e |
Contributor
There was a problem hiding this comment.
Just curious about git submodule update --init --recursive webassets || true vs git submodule update --init --recursive packages/webapps.e. Why does the former need || true and the latter doesn't?
Contributor
Author
There was a problem hiding this comment.
Good catch, thank you. Updated to include || true
Contributor
Author
There was a problem hiding this comment.
Actually, removed || true as this command shouldn't be allowed to fail.
Contributor
There was a problem hiding this comment.
Do you know why failure is allowed for webassets?
rosstimothy
reviewed
Oct 12, 2022
rosstimothy
approved these changes
Oct 12, 2022
avatus
added a commit
that referenced
this pull request
Oct 12, 2022
* add windows submodule support for connect builds * added connect enterprise support to mac builds * update submodule command * removed ability to fail webapps.e and recursive * dronegen
avatus
added a commit
that referenced
this pull request
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging Access Requests, Teleport Connect will need access to the webapps.e repo. This change will init the required submodule during the submodule phase in webapps.