Skip to content

[v10] fix: Handle failures when checking for excluded credentials#16765

Merged
codingllama merged 2 commits into
branch/v10from
bot/backport-16737-branch/v10
Sep 27, 2022
Merged

[v10] fix: Handle failures when checking for excluded credentials#16765
codingllama merged 2 commits into
branch/v10from
bot/backport-16737-branch/v10

Conversation

@codingllama
Copy link
Copy Markdown
Contributor

U2F devices, like the Yubikey4, fail in a slightly unexpected way when
assertions set UP=false. Handle this edge case and also make sure that failures
when checking for excluded credentials won't break the entire ceremony.

Similar to #15975, but in the registration flow this time.

Repro steps:

  1. Register a Yubikey 4
  2. Attempt to register a different security key
  3. Registration fails with a "user presence required" error

Backport #16737 to branch/v10

@github-actions github-actions Bot removed the request for review from tobiaszheller September 27, 2022 18:35
@codingllama codingllama force-pushed the bot/backport-16737-branch/v10 branch from 8e66693 to 90bc23b Compare September 27, 2022 21:40
@codingllama codingllama merged commit 9777fa9 into branch/v10 Sep 27, 2022
@codingllama codingllama deleted the bot/backport-16737-branch/v10 branch September 27, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants