fix: Handle failures when checking for excluded credentials#16737
Merged
Conversation
Tener
approved these changes
Sep 27, 2022
tobiaszheller
approved these changes
Sep 27, 2022
Contributor
tobiaszheller
left a comment
tobiaszheller
left a comment
There was a problem hiding this comment.
lgtm although cannot reproduce
codingllama
force-pushed
the
codingllama/u2f-excluded-credential
branch
from
99d39bc to
4bdc87f
Compare
Contributor
Author
|
Friendly ping @jakule ? |
zmb3
approved these changes
Sep 27, 2022
codingllama
force-pushed
the
codingllama/u2f-excluded-credential
branch
from
4bdc87f to
682084c
Compare
Contributor
|
@codingllama See the table below for backport results.
|
codingllama
added a commit
that referenced
this pull request
Sep 27, 2022
…6765) U2F devices, like the Yubikey4, fail in a slightly unexpected way when assertions set UP=false. Handle this edge case and also make sure that failures when checking for excluded credentials won't break the entire ceremony. Similar to #15975, but in the registration flow this time. Repro steps: 1. Register a Yubikey 4 2. Attempt to register a different security key 3. Registration fails with a "user presence required" error Backport #16737 to branch/v10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
U2F devices, like the Yubikey4, fail in a slightly unexpected way when assertions set UP=false. Handle this edge case and also make sure that failures when checking for excluded credentials won't break the entire ceremony.
Similar to #15975, but in the registration flow this time.
Repro steps: