Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10] Error out if port is already bound #13464 #14886

Merged
merged 2 commits into from
Jul 27, 2022
Merged

[v10] Error out if port is already bound #13464 #14886

merged 2 commits into from
Jul 27, 2022

Conversation

EdwardDowling
Copy link
Contributor

@EdwardDowling EdwardDowling commented Jul 26, 2022 •
edited
Loading

Backport of #13464

@EdwardDowling EdwardDowling changed the title [v10] Error out if port is already bound [v10] Error out if port is already bound #13464 Jul 26, 2022
@github-actions github-actions bot requested review from hatched, timothyb89 and zmb3 July 26, 2022 16:48
@EdwardDowling EdwardDowling linked an issue Jul 26, 2022 that may be closed by this pull request
tsh does not correctly error when binding to a local port already in use #11293
Closed
@github-actions github-actions bot removed the request for review from timothyb89 July 26, 2022 19:47
@EdwardDowling EdwardDowling enabled auto-merge (squash) July 27, 2022 09:06
@EdwardDowling EdwardDowling merged commit 7161c0f into branch/v10 Jul 27, 2022
@zmb3 zmb3 deleted the backport/branch/v10/pr-13464 branch September 9, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hatched hatched hatched approved these changes

@zmb3 zmb3 zmb3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tsh does not correctly error when binding to a local port already in use
3 participants
@EdwardDowling @hatched @zmb3