Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error out if port is already bound #13464

Merged
merged 7 commits into from
Jun 15, 2022

Conversation

EdwardDowling
Copy link
Contributor

@EdwardDowling EdwardDowling commented Jun 14, 2022

Error out and return if local port is already bound when trying to port forward.

error now looks like
ERROR: Failed to bind to 127.0.0.1:4567: listen tcp 127.0.0.1:4567: bind: address already in use.

closes #11293

@EdwardDowling EdwardDowling marked this pull request as ready for review June 14, 2022 09:21
@github-actions github-actions bot requested review from hatched and timothyb89 June 14, 2022 09:22
@EdwardDowling EdwardDowling changed the title Error out if port is already bound #11293 Error out if port is already bound Jun 14, 2022
@EdwardDowling EdwardDowling merged commit 47f406e into master Jun 15, 2022
EdwardDowling added a commit that referenced this pull request Jul 27, 2022
Error out if port is already bound
EdwardDowling added a commit that referenced this pull request Jul 28, 2022
Error out if port is already bound
@zmb3 zmb3 deleted the edwarddowling/tsh-local-port-binding branch April 26, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tsh does not correctly error when binding to a local port already in use
3 participants