[v9] Don't enforce standard k8s and ssh auth mechanisms when joining sessions#12543
Closed
[v9] Don't enforce standard k8s and ssh auth mechanisms when joining sessions#12543
Conversation
github-actions
Bot
added
kubernetes
tsh
espadolini
approved these changes
May 11, 2022
Contributor
espadolini
left a comment
espadolini
left a comment
There was a problem hiding this comment.
LGTM but I'm a bit worried about supporting v8 clusters with a v9 tsh; are we ok with user expectations growing like that?
Contributor
Author
|
I'm mostly bolting on support here because it's easy to do, doesn't require serverside changes and because our versioning guide doesn't really specify it + the fact that we've that similar things happen before with users eagerly upgrading. If we decide against it I'd be happy to drop support. EDIT: we need to support v9 servers that predate this change too. |
zmb3
approved these changes
May 20, 2022
Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
xacrimon
force-pushed
the
joel/v9/backport-11144
branch
from
803bdae to
c80cd6c
Compare
Contributor
Author
|
Closing this out since it seems better to not change the permission system in an already released major. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of:
Also includes changes to the tsh join metadata retrieval to special-case sub-v9 servers for compatibility. Only v9+ auths support sessiontracker so we need to use the legacy system to find sessions if the cluster auth is pre-v9.