Don't enforce standard k8s and ssh auth mechanisms when joining sessions#11144
Merged
Don't enforce standard k8s and ssh auth mechanisms when joining sessions#11144
Conversation
espadolini
reviewed
Mar 15, 2022
ee78096 to
671d7d1
Compare
espadolini
reviewed
Mar 15, 2022
zmb3
approved these changes
Mar 15, 2022
Collaborator
zmb3
left a comment
There was a problem hiding this comment.
Looks okay to me other than the minor suggestions here, but I am not super familiar with this code.
espadolini
approved these changes
Mar 15, 2022
Contributor
|
@xacrimon Can you add test coverage to this PR? |
r0mant
requested changes
Mar 15, 2022
r0mant
reviewed
Mar 15, 2022
Collaborator
|
@xacrimon Just checking, are we going to close this one and go with a different approach? |
Contributor
Author
e95ebdc to
61683e6
Compare
8ccee72 to
c7d7b23
Compare
Contributor
Author
|
@r0mant Can you take another look at this PR please since you left a request-changes status last? |
23855ca to
5136056
Compare
Contributor
Author
|
friendly ping: @r0mant |
r0mant
approved these changes
Apr 25, 2022
Joerger
reviewed
May 5, 2022
xacrimon
added a commit
that referenced
this pull request
May 10, 2022
xacrimon
added a commit
that referenced
this pull request
May 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently enforce standard SSH and K8S auth mechanisms to determine resource access in addition to the Moderated Sessions join check, we shouldn't do this since it prevents configuring the ability to join sessions without the ability to start them.
Notable changes:
sessionservice and the semi-hacky metadata keys.This is well covered by existing tests, relevant tests have been adjusted.