[v7] backport #10741 (leaf cluster CA sanitizing)#10744
Merged
Conversation
espadolini
added
security
Clients before 9 shouldn't ask for filtered CA watches as the server side might be of a higher major version but not support them; we rely entirely on the backwards compatibility filter injection in that case.
r0mant
approved these changes
Mar 2, 2022
zmb3
approved these changes
Mar 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10741 and #10020.
As a major version n node can connect to any major version n+1 auth, for versions 7 and below (not 8, because v9 will support CA filtering since 9.0.0) we rely entirely on the server-side filter injection for CA filtering.
This also fixes an issue introduced in #10226 when backporting #9822 down to v6, as in v7 and v6 there's still an if/else if/else chain in events.FromOneOf that was removed in v8 and above.