Leaf cluster CA sanitizing#10741
Merged
espadolini merged 5 commits intomasterfrom Mar 3, 2022
Merged
Conversation
espadolini
added
security
This was referenced Mar 2, 2022
espadolini
force-pushed
the
espadolini/remotecluster-ca-sanitize
branch
from
3333c8f to
6f04c6b
Compare
r0mant
approved these changes
Mar 2, 2022
lxea
approved these changes
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also blanks the
role_mapandrolesproperty of the received CA, for sanity (the role map shouldn't be relevant with host CAs).To allow users to manually clean up spurious CAs that were injected as a result of the bug, this PR adds the ability to delete CAs with
tctl: