This repository was archived by the owner on Jun 4, 2024. It is now read-only.
Compile plugins as static (CGO_ENABLED=0)#936
Merged
Conversation
reedloden
requested review from
Joerger,
camscale,
fheinecke,
klizhentas,
r0mant,
russjones,
tcsc and
zmb3
as code owners
reedloden
changed the title
CGO_ENABLED=0)
espadolini
approved these changes
Sep 29, 2023
marcoandredinis
approved these changes
Sep 29, 2023
The change to distroless static in #928 broke plugin binaries, as the distroless image doesn't have glibc. However, there's no reason for the plugins to need glibc, so just change them to all `CGO_ENABLED=0`. Additionally, some minor fixes: * Change one place where `GO_VERSION` wasn't properly set/updated. * Correct build process for `access/email`. * Remove reference to previously removed `access/example`. Fixes #935.
reedloden
force-pushed
the
reed/static-binaries
branch
from
9db59c1 to
1bc2b3d
Compare
marcoandredinis
approved these changes
Sep 29, 2023
zmb3
approved these changes
Sep 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change to distroless static in #928 broke plugin binaries, as the distroless image doesn't have glibc. However, there's no reason for the plugins to need glibc, so just change them to all
CGO_ENABLED=0.Additionally, some minor fixes:
GO_VERSIONwasn't properly set/updated.access/email.access/example.Fixes #935.