This repository was archived by the owner on Jun 4, 2024. It is now read-only.
Update base docker images to use Debian 12 distroless static image#928
Merged
Update base docker images to use Debian 12 distroless static image#928
static image#928Conversation
reedloden
added
release-engineering
reedloden
requested review from
Joerger,
camscale,
fheinecke,
klizhentas,
r0mant,
russjones,
tcsc and
zmb3
as code owners
tcsc
approved these changes
Sep 26, 2023
jakule
approved these changes
Sep 26, 2023
reedloden
force-pushed
the
reed/distroless-debian12
branch
from
6d64f30 to
edc30fd
Compare
reedloden
changed the title
static image
reedloden
force-pushed
the
reed/distroless-debian12
branch
from
edc30fd to
b02a444
Compare
Contributor
|
This broke |
reedloden
added a commit
that referenced
this pull request
Sep 29, 2023
The change to distroless static in #928 broke plugin binaries, as the distroless image doesn't have glibc. However, there's no reason for the plugins to need glibc, so just change them to all `CGO_ENABLED=0`. Additionally, some minor fixes: * Change one place where `GO_VERSION` wasn't properly set/updated. * Correct build process for `access/email`. * Remove reference to previously removed `access/example`. Fixes #935.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of chasing ever-changing commit hashes, just use the apppropriate tag for the distroless image. This aligns things to how
teleportis handled (gravitational/teleport#31620).Additionally, standardize on Debian 12 for everything (instead of a mix of 11 and 12). Also, use
staticoverbase. This means noglibcorlibssl, which should be fine for these plugins.Alternative to #924 and #915.