-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update esbuild.js #3480
Update esbuild.js #3480
Conversation
A possibly naive way to make vscode extension work after esbuild upgrade.
🦋 Changeset detectedLatest commit: 56f0851 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
oh great, this approach wasn't working before. did you test with URL schema or sdl file schema or both? and you tested by installing the locally generated vsix bundle? |
Turns out I was quite naive about just excluding graphql-config. The extension worked under the Test Runner, but not when bundled and installed. This change actually does work, even when the plugin is bundled and installed separately. It uses the technique outlined in evanw/esbuild#2441
Turns out I was naive - merely making graphql-config an external package stopped that particular error, and worked in VSCodes extension runner, but failed when I bundled the extension and installed it on its own. This fix actually does work, inspired by evanw/esbuild#1492. I exported it as a .vsix bundle, installed it locally, and tried it with both URL and file-based Graphql Schemas, and it worked in every case. |
@craig-riecke awesome, thank you for looking it into me! this is the last piece we needed. now i can add an e2e test suite hopefully! |
@craig-riecke also can you add a changeset so we can kick off a patch release for this? perhaps even a minor release now that it's working again (new feature: it works 😆 ) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3480 +/- ##
==========================================
+ Coverage 55.75% 55.81% +0.06%
==========================================
Files 110 110
Lines 5243 5273 +30
Branches 1426 1439 +13
==========================================
+ Hits 2923 2943 +20
- Misses 1897 1901 +4
- Partials 423 429 +6
|
works for me as well on vsix bundle! awesome to see now i see a bug though where it reports a successful response as an error, so I can fix that in another PR update: there was a schema issue, looks great! |
This is probably a naive fix, but it does make the extension work again in my copy of VSCode.
Fixes #3171